Looks OK - but see unit test failure on merged branch:
======================================================================
ERROR: test_config_changed_single_consoleauth (unit_tests.test_nova_cc_hooks.NovaCCHooksTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/mock.py", line 1210, in patched
return func(*args, **keywargs)
File "/home/jamespage/src/charms/git/nova-cloud-controller/unit_tests/test_nova_cc_hooks.py", line 800, in test_config_changed_single_consoleauth
hooks.config_changed()
File "hooks/nova_cc_utils.py", line 1005, in wrapped_f
f(*args)
File "hooks/charmhelpers/core/host.py", line 312, in wrapped_f
f(*args, **kwargs)
File "hooks/nova_cc_hooks.py", line 180, in config_changed
if config_value_changed('openstack-origin-git'):
File "hooks/charmhelpers/contrib/openstack/utils.py", line 346, in config_value_changed
with hook_data():
File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
return self.gen.next()
File "hooks/charmhelpers/core/unitdata.py", line 425, in __call__
self._record_charm_version(hookenv.charm_dir())
File "hooks/charmhelpers/core/unitdata.py", line 435, in _record_charm_version
os.path.join(charm_dir, 'revision')).read().strip()
File "/usr/lib/python2.7/posixpath.py", line 70, in join
elif path == '' or path.endswith('/'):
AttributeError: 'NoneType' object has no attribute 'endswith'
Looks OK - but see unit test failure on merged branch:
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= changed_ single_ consoleauth (unit_tests. test_nova_ cc_hooks. NovaCCHooksTest s) ------- ------- ------- ------- ------- ------- ------- ------- ------- python2. 7/dist- packages/ mock.py" , line 1210, in patched jamespage/ src/charms/ git/nova- cloud-controlle r/unit_ tests/test_ nova_cc_ hooks.py" , line 800, in test_config_ changed_ single_ consoleauth config_ changed( ) nova_cc_ utils.py" , line 1005, in wrapped_f charmhelpers/ core/host. py", line 312, in wrapped_f nova_cc_ hooks.py" , line 180, in config_changed value_changed( 'openstack- origin- git'): charmhelpers/ contrib/ openstack/ utils.py" , line 346, in config_ value_changed python2. 7/contextlib. py", line 17, in __enter__ charmhelpers/ core/unitdata. py", line 425, in __call__ _record_ charm_version( hookenv. charm_dir( )) charmhelpers/ core/unitdata. py", line 435, in _record_ charm_version path.join( charm_dir, 'revision' )).read( ).strip( ) python2. 7/posixpath. py", line 70, in join
ERROR: test_config_
-------
Traceback (most recent call last):
File "/usr/lib/
return func(*args, **keywargs)
File "/home/
hooks.
File "hooks/
f(*args)
File "hooks/
f(*args, **kwargs)
File "hooks/
if config_
File "hooks/
with hook_data():
File "/usr/lib/
return self.gen.next()
File "hooks/
self.
File "hooks/
os.
File "/usr/lib/
elif path == '' or path.endswith('/'):
AttributeError: 'NoneType' object has no attribute 'endswith'