Code review comment for lp:~corey.bryant/charms/trusty/keystone/git

Please reconsider hard-coding squid proxy values to the Canonical internal http proxy. If we do this, then when third parties attempt to contribute to the charm, they won't be able to run the tests successfully.

Instead, it would be safer to detect whether or not the AMULET_HTTP_PROXY environment variable is set, and if it is, proceed to set http_proxy and https_proxy equal to AMULET_HTTP_PROXY.

This is regarding _configure_services in the tests/basic_deployment.py file.

Thank you!