Code review comment for lp:~corey.bryant/charms/trusty/keystone/amulet-basic

Revision history for this message
Corey Bryant (corey.bryant) wrote :

I've pushed a new version with the following updates:
 *Makefile - Use standard target names test and unit_test per https://docs.google.com/a/canonical.com/document/d/1Lb86vjXG7ZnVqDq8idNa5-rx_VB728Qacxm4U7IutgE/edit#
 *amulet_utils.py - Change get_logger() defaults.
 *amulet_utils.py - Added validate_flavor_data() and _validate_list_data() (used by nova-cloud-controller charm)
 *amulet_utils.py - Added -f option to pgrep in _get_proc_start_time() to match against full command line (not just process name) and only use first pid found
 *amulet_utils.py - Added more code to validate_endpoint_data(), making calls to this function simpler
 *basic_deployment.py - Simplified code in test_keystone_endpoint() and test_cinder_endpoint()
 *basic_deployment.py - test_keystone_shared_db_relation() - changed expected 'auth_host' value to utils.valid_ip
 *basic_deployment.py - Changed test_restart_on_config_change() to check for restart of keystone-all service instead of keystone

« Back to merge proposal