Code review comment for lp:~compiz-team/compiz/gles2.scope_of_empty_vb_check

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

On Wed, 8 Aug 2012, Daniel van Vugt wrote:

> I like information hiding, but still suspect you will encounter lots of plugins where it won't work. Unless you expose the whole GLVertexBuffer interface through GLWindow, but that's just nasty.
>
> If you have an idea for improving information hiding, test that it works and then propose it. So long as we don't have to touch vast amounts of plugin code...
>
> As for now, I'll just do the "end() returns bool" thing.

Okay, I only have to touch two plugins and its very noninvasive. I will
propose it in the next few minutes

> --
> https://code.launchpad.net/~compiz-team/compiz/gles2.scope_of_empty_vb_check/+merge/117058
> Your team Compiz Maintainers is subscribed to branch lp:~compiz-team/compiz/gles2.scope_of_empty_vb_check.
>

« Back to merge proposal