Merge lp:~compiz-team/compiz/fix-1051595 into lp:compiz/0.9.8

Proposed by Daniel van Vugt
Status: Superseded
Proposed branch: lp:~compiz-team/compiz/fix-1051595
Merge into: lp:compiz/0.9.8
Diff against target: 38 lines (+5/-14)
1 file modified
cmake/base.cmake (+5/-14)
To merge this branch: bzr merge lp:~compiz-team/compiz/fix-1051595
Reviewer Review Type Date Requested Status
jenkins (community) continuous-integration Needs Fixing
Compiz Maintainers Pending
Review via email: mp+124866@code.launchpad.net

This proposal has been superseded by a proposal from 2012-09-18.

Commit message

Some problems with make findcompiz_install and make findcompizconfig_install
- make findcompiz_install errors since r3320
- in r3219 installs the findcompiz*.cmake-files with a normal make install,
but not in the Modules directory. This is a) wrong and b) not according to
the message that findcompiz* must be installed with make findcompiz_install.
Patch fixes this, by removing the extra file install with make install, and
cleaning up the building of the findcompiz-target.
(LP: #1051595)

Description of the change

Some problems with make findcompiz_install and make findcompizconfig_install
- make findcompiz_install errors since r3320
- in r3219 installs the findcompiz*.cmake-files with a normal make install,
but not in the Modules directory. This is a) wrong and b) not according to
the message that findcompiz* must be installed with make findcompiz_install.
Patch fixes this, by removing the extra file install with make install, and
cleaning up the building of the findcompiz-target.
(LP: #1051595)

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

3378. By erikjanp

Some problems with make findcompiz_install and make findcompizconfig_install
- make findcompiz_install errors since r3320
- in r3219 installs the findcompiz*.cmake-files with a normal make install,
but not in the Modules directory. This is a) wrong and b) not according to
the message that findcompiz* must be installed with make findcompiz_install.
Patch fixes this, by removing the extra file install with make install, and
cleaning up the building of the findcompiz-target.
(LP: #1051595)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/base.cmake'
2--- cmake/base.cmake 2012-05-26 10:52:26 +0000
3+++ cmake/base.cmake 2012-09-18 09:33:21 +0000
4@@ -49,15 +49,10 @@
5 message ("Call \"sudo make findcompiz_install\" to install it.\n")
6 compiz_print_configure_footer ()
7 endif ()
8- install (FILES
9- ${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindCompiz.cmake
10- ${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindOpenGLES2.cmake
11- DESTINATION
12- ${CMAKE_INSTALL_PREFIX}/share/cmake-${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}/)
13 add_custom_target (findcompiz_install
14- ${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules &&
15- ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindCompiz.cmake ${CMAKE_ROOT}/Modules
16- ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindOpenGLES2.cmake ${CMAKE_ROOT}/Modules
17+ COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules
18+ COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindCompiz.cmake ${CMAKE_ROOT}/Modules
19+ COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_SOURCE_DIR}/cmake/FindOpenGLES2.cmake ${CMAKE_ROOT}/Modules
20 )
21 find_file (_find_compizconfig FindCompizConfig.cmake PATHS ${CMAKE_ROOT}/Modules ${ARGN})
22 if (NOT _find_compizconfig)
23@@ -67,14 +62,10 @@
24 message ("Call \"sudo make findcompiz_install\" to install it.\n")
25 compiz_print_configure_footer ()
26 endif (NOT _find_compizconfig)
27- install (FILES
28- ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig/libcompizconfig/cmake/FindCompizConfig.cmake
29- DESTINATION
30- ${CMAKE_INSTALL_PREFIX}/share/cmake-${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}/)
31 add_custom_target (
32 findcompizconfig_install
33- ${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules &&
34- ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig/libcompizconfig/cmake/FindCompizConfig.cmake ${CMAKE_ROOT}/Modules
35+ COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_ROOT}/Modules
36+ COMMAND ${CMAKE_COMMAND} -E copy ${CMAKE_CURRENT_SOURCE_DIR}/compizconfig/libcompizconfig/cmake/FindCompizConfig.cmake ${CMAKE_ROOT}/Modules
37 )
38 endfunction ()
39

Subscribers

People subscribed via source and target branches