On Sun, Feb 10, 2013 at 8:28 PM, MC Return <email address hidden> wrote:
> 165 + * This since this code only draws a rectangular region from one
> should probably be:
> 165 + * Since this code only draws a rectangular region from one
>
> The copyright in plugins/opengl/include/opengl/opengl-api.h seems to be incorrect.
Thanks, I'll update it.
>
> Is the fallthrough in plugins/opengl/src/framebufferobject.cpp intentional ?
> 1323 switch (status)
> 1324 {
> 1325 - case GL::FRAMEBUFFER_COMPLETE:
> 1326 + case GL::FRAMEBUFFER_COMPLETE:
> 1327 return "GL::FRAMEBUFFER_COMPLETE";
> 1328 - case GL::FRAMEBUFFER_INCOMPLETE_ATTACHMENT:
> 1329 + case GL::FRAMEBUFFER_INCOMPLETE_ATTACHMENT:
> 1330 return "GL::FRAMEBUFFER_INCOMPLETE_ATTACHMENT";
> 1331 - case GL::FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT:
> 1332 + case GL::FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT:
> 1333 return "GL::FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT";
> 1334 - case GL::FRAMEBUFFER_INCOMPLETE_DIMENSIONS:
> 1335 + case GL::FRAMEBUFFER_INCOMPLETE_DIMENSIONS:
> 1336 return "GL::FRAMEBUFFER_INCOMPLETE_DIMENSIONS";
> 1337 - case GL::FRAMEBUFFER_UNSUPPORTED:
> 1338 + case GL::FRAMEBUFFER_UNSUPPORTED:
> 1339 return "GL::FRAMEBUFFER_UNSUPPORTED";
> 1340 default:
> 1341 return "unexpected status";
> 1342 }
>
No fall-through is possible, since we return directly.
On Sun, Feb 10, 2013 at 8:28 PM, MC Return <email address hidden> wrote: opengl/ include/ opengl/ opengl- api.h seems to be incorrect.
> 165 + * This since this code only draws a rectangular region from one
> should probably be:
> 165 + * Since this code only draws a rectangular region from one
>
> The copyright in plugins/
Thanks, I'll update it.
> opengl/ src/framebuffer object. cpp intentional ? _COMPLETE: _COMPLETE: R_COMPLETE" ; _INCOMPLETE_ ATTACHMENT: _INCOMPLETE_ ATTACHMENT: R_INCOMPLETE_ ATTACHMENT" ; _INCOMPLETE_ MISSING_ ATTACHMENT: _INCOMPLETE_ MISSING_ ATTACHMENT: R_INCOMPLETE_ MISSING_ ATTACHMENT" ; _INCOMPLETE_ DIMENSIONS: _INCOMPLETE_ DIMENSIONS: R_INCOMPLETE_ DIMENSIONS" ; _UNSUPPORTED: _UNSUPPORTED: R_UNSUPPORTED" ;
> Is the fallthrough in plugins/
> 1323 switch (status)
> 1324 {
> 1325 - case GL::FRAMEBUFFER
> 1326 + case GL::FRAMEBUFFER
> 1327 return "GL::FRAMEBUFFE
> 1328 - case GL::FRAMEBUFFER
> 1329 + case GL::FRAMEBUFFER
> 1330 return "GL::FRAMEBUFFE
> 1331 - case GL::FRAMEBUFFER
> 1332 + case GL::FRAMEBUFFER
> 1333 return "GL::FRAMEBUFFE
> 1334 - case GL::FRAMEBUFFER
> 1335 + case GL::FRAMEBUFFER
> 1336 return "GL::FRAMEBUFFE
> 1337 - case GL::FRAMEBUFFER
> 1338 + case GL::FRAMEBUFFER
> 1339 return "GL::FRAMEBUFFE
> 1340 default:
> 1341 return "unexpected status";
> 1342 }
>
No fall-through is possible, since we return directly.
> -- /code.launchpad .net/~compiz- team/compiz/ compiz. performance_ 1040478/ +merge/ 147541
> https:/
> You proposed lp:~compiz-team/compiz/compiz.performance_1040478 for merging.
--
Sam Spilsbury