Created by Sam Spilsbury on 2013-06-05 and last modified on 2013-06-05
Get this branch:
bzr branch lp:~compiz-team/compiz/compiz.fix_1186723
Members of Compiz Maintainers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Compiz Maintainers

Recent revisions

3736. By Sam Spilsbury on 2013-06-05

Fixes LP #1186723

3735. By Sam Spilsbury on 2013-06-05

Don't adjust windows with a static gravity for their decorations.

They will adjust themselves.

(LP: #1168723)

3734. By Sam Spilsbury on 2013-06-04

Satisfy matchers on getProperty as soon as they are set.

The order of evaluation for matchers in Google Mock appears to be
undefined - this means that we can't rely on the first argument being
matched first and the second argument being matched afterwards. In turn,
this means that any GValue may be passed to a GValueMatch which, by a
design flaw, is unable to handle any values of a type it does not expect
(at least not without an API change). It will silently pass the incorrect
type to g_type_get_* which causes internal assertion failures.

At the moment we're just interleaving the calls to getProperty and
get_property - that way the expectations are satisfied and go away
as soon as they're set. This in turn means that Google Mock only
has to traverse one matcher rather than multiple matchers.

(LP: #1187468)

3733. By MC Return on 2013-06-01

Fix for cube.cpp, regression r3720 - Inner sides of cube invisible now.
Wrong variable type was accidentially used, cullInv is of type int, not bool.

(LP: #1183852). Fixes: https://bugs.launchpad.net/bugs/1184852.

Approved by PS Jenkins bot, Sam Spilsbury.

3732. By kolya on 2013-06-01

When static switcher is enabled and has an option to show application icon turned on the icons are expected to be ~1/3 of a thumbnail (48px). Instead they are displayed in 512px size and completely cover everything. This change addresses this issue. See LP #1173914. Fixes: https://bugs.launchpad.net/bugs/1186426.

Approved by PS Jenkins bot, Sam Spilsbury, MC Return.

3731. By MC Return on 2013-05-31

window.cpp code cleanup:

Declare variables outside of loops.
Reduced the scope of variables.
Do not assign values to variables if those values are not used.
Always bail out of functions ASAP, do not calculate stuff you might not need.
Use pre- instead of postfix de- and increments.
Declaration and assignment of variables in one line.
Merged if condition checks.
Added and removed brackets.
Added and removed newlines.
Fixed indentation.
Added TODOs (removal of magic numbers).

Approved by PS Jenkins bot, Sam Spilsbury.

3730. By MC Return on 2013-05-31

Widget, minor code cleanup:

Declaration and assignment of local variables in one line.
Merged if condition checks.
Added and removed newlines.
Added default case to switch (just a style issue).
Removed redundant brackets.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3729. By Sam Spilsbury on 2013-05-29

Added some new hooks to PluginClassHandler to allow a VTable to specify if loaded.

PluginClassHandler::get () was designed to simply instantiate an instance of that
class for the core structure, but it did this without checking if the plugin was

Added some new methods to PluginClassHandler exposed by LoadedPluginClassBridge
and only accessible by those who implement PluginKey to specify globally
whether or not a plugin is actually loaded, so that PluginClassHandler can
return accordingly.

Integration and unit tests added as appropriate

(LP: #1169620)
(LP: #1101026). Fixes: https://bugs.launchpad.net/bugs/1101026, https://bugs.launchpad.net/bugs/1169620.

Approved by PS Jenkins bot, Brandon Schaefer.

3728. By Sam Spilsbury on 2013-05-29

Change the behaviour of undecorating windows.

Previously when a window was undecorated, we would shift it back to an appropriate position according to its gravity member. That behaviour was problematic because in the StaticGravity case the window has to just stay in the same place. But then if you had a window with StaticGravity which then did get a decoration and later removed it, it would be placed as though it was decorated and appear to be in the wrong place.

The correct behaviour is to place all windows as though they have decorations, and then when decorations are removed, to move the window back to the corner as indicated in its gravity and then expand its size to cover the obscured regions no longer hidden because the decorations went away.

(LP: #1165343).

Approved by PS Jenkins bot, Brandon Schaefer, MC Return.

3727. By MC Return on 2013-05-28

Opacify code cleanup:

Declaration of local variables outside of loops.
Calculate activeOpacity and targetOpacity just once, not for each window.
Use prefix instead of postfix increments.
Merged if condition checks.
Declaration and assignment of local variables in one line.
Added and removed newlines.
Removed redundant brackets.
Fixed indentation.

Opacify, functionality fix:

Improved the toggling logic by setting isToggle in the constructor according to
the startup setting, then calling setFunctions (isToggle);,which then calls
screen->handleEventSetEnabled (os, os->isToggle); to fix Opacify ignoring the
"Toggle Opacify on by default" setting.

(LP: #787814). Fixes: https://bugs.launchpad.net/bugs/787814.

Approved by PS Jenkins bot, Sam Spilsbury.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.