Code review comment for lp:~compiz-team/compiz/compiz.fix_1131864

Getting much further now, but some Boost troubles unfortunately remain:

[ 75%] Building CXX object plugins/ezoom/CMakeFiles/ezoom.dir/src/ezoom.cpp.o
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp: In constructor ‘DecorScreen::DecorScreen(CompScreen*)’:
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:3049:48: error: no matching function for call to ‘boost::shared_array<_decor_quad>::shared_array(NULL)’
        boost::shared_array <decor_quad_t> (NULL),
                                                ^
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:3049:48: note: candidates are:
In file included from /usr/include/boost/shared_array.hpp:17:0,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.h:27,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:38:
/usr/include/boost/smart_ptr/shared_array.hpp:126:5: note: template<class Y> boost::shared_array<T>::shared_array(const boost::shared_array<Y>&, boost::shared_array<T>::element_type*)
     shared_array( shared_array<Y> const & r, element_type * p ) BOOST_NOEXCEPT : px( p ), pn( r.pn )
     ^
/usr/include/boost/smart_ptr/shared_array.hpp:126:5: note: template argument deduction/substitution failed:
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:3049:48: note: mismatched types ‘const boost::shared_array<T>’ and ‘long int’
        boost::shared_array <decor_quad_t> (NULL),
                                                ^
In file included from /usr/include/boost/shared_array.hpp:17:0,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.h:27,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:38:
/usr/include/boost/smart_ptr/shared_array.hpp:111:5: note: template<class Y> boost::shared_array<T>::shared_array(const boost::shared_array<Y>&, typename boost::detail::sp_enable_if_convertible<Y [], T []>::type)
     shared_array( shared_array<Y> const & r, typename boost::detail::sp_enable_if_convertible< Y[], T[] >::type = boost::detail::sp_empty() )
     ^
/usr/include/boost/smart_ptr/shared_array.hpp:111:5: note: template argument deduction/substitution failed:
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:3049:48: note: mismatched types ‘const boost::shared_array<T>’ and ‘long int’
        boost::shared_array <decor_quad_t> (NULL),
                                                ^
In file included from /usr/include/boost/shared_array.hpp:17:0,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.h:27,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:38:
/usr/include/boost/smart_ptr/shared_array.hpp:83:41: note: template<class Y, class D, class A> boost::shared_array<T>::shared_array(Y*, D, A)
     template<class Y, class D, class A> shared_array( Y * p, D d, A a ): px( p ), pn( p, d, a )
                                         ^
/usr/include/boost/smart_ptr/shared_array.hpp:83:41: note: template argument deduction/substitution failed:
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:3049:48: note: mismatched types ‘Y*’ and ‘long int’
        boost::shared_array <decor_quad_t> (NULL),
                                                ^
In file included from /usr/include/boost/shared_array.hpp:17:0,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.h:27,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:38:
/usr/include/boost/smart_ptr/shared_array.hpp:76:32: note: template<class Y, class D> boost::shared_array<T>::shared_array(Y*, D)
     template<class Y, class D> shared_array( Y * p, D d ): px( p ), pn( p, d )
                                ^
/usr/include/boost/smart_ptr/shared_array.hpp:76:32: note: template argument deduction/substitution failed:
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:3049:48: note: mismatched types ‘Y*’ and ‘long int’
        boost::shared_array <decor_quad_t> (NULL),
                                                ^
In file included from /usr/include/boost/shared_array.hpp:17:0,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.h:27,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:38:
/usr/include/boost/smart_ptr/shared_array.hpp:65:14: note: template<class Y> boost::shared_array<T>::shared_array(Y*)
     explicit shared_array( Y * p ): px( p ), pn( p, checked_array_deleter<Y>() )
              ^
/usr/include/boost/smart_ptr/shared_array.hpp:65:14: note: template argument deduction/substitution failed:
/home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:3049:48: note: mismatched types ‘Y*’ and ‘long int’
        boost::shared_array <decor_quad_t> (NULL),
                                                ^
In file included from /usr/include/boost/shared_array.hpp:17:0,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.h:27,
                 from /home/mcr2010/src/bzr/compiz.fix_1131864/plugins/decor/src/decor.cpp:38:
/usr/include/boost/smart_ptr/shared_array.hpp:60:5: note: boost::shared_array<T>::shared_array() [with T = _decor_quad]
     shared_array() BOOST_NOEXCEPT : px( 0 ), pn()
     ^
/usr/include/boost/smart_ptr/shared_array.hpp:60:5: note: candidate expects 0 arguments, 1 provided
/usr/include/boost/smart_ptr/shared_array.hpp:48:25: note: boost::shared_array<_decor_quad>::shared_array(const boost::shared_array<_decor_quad>&)
 template<class T> class shared_array
                         ^
/usr/include/boost/smart_ptr/shared_array.hpp:48:25: note: no known conversion for argument 1 from ‘long int’ to ‘const boost::shared_array<_decor_quad>&’
[ 75%] Building CXX object plugins/kdecompat/CMakeFiles/kdecompat.dir/__/__/generated/kdecompat_options.cpp.o
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-unused-private-field" [enabled by default]
cc1plus: warning: unrecognized command line option "-Wno-unused-private-field" [enabled by default]
cc1plus: warning: unrecognized command line option "-Wno-unused-private-field" [enabled by default]
cc1plus: warning: unrecognized command line option "-Wno-unused-private-field" [enabled by default]
cc1plus: warning: unrecognized command line option "-Wno-unused-private-field" [enabled by default]
cc1plus: warning: unrecognized command line option "-Wno-unused-private-field" [enabled by default]
make[2]: *** [plugins/decor/CMakeFiles/decor.dir/src/decor.cpp.o] Error 1
make[1]: *** [plugins/decor/CMakeFiles/decor.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....