Code review comment for lp:~compiz-team/compiz/compiz.fix_1131864

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> This MP still throws some errors with Boost 1.53:
>
> /home/mcr2010/src/bzr/compiz.fix_1131864/src/window.cpp: In function ‘bool
> isPendingRestack(const Ptr&)’:
> /home/mcr2010/src/bzr/compiz.fix_1131864/src/window.cpp:3027:2: error:
> ‘shared_static_cast’ is not a member of ‘boost’
> boost::shared_static_cast <compiz::X11::PendingConfigureEvent> (p);
> ^
> /home/mcr2010/src/bzr/compiz.fix_1131864/src/window.cpp:3027:63: error:
> expected primary-expression before ‘>’ token
> boost::shared_static_cast <compiz::X11::PendingConfigureEvent> (p);
> ^
> /home/mcr2010/src/bzr/compiz.fix_1131864/src/window.cpp: In function ‘bool
> isExistingRequest(const Ptr&, XWindowChanges&, unsigned int)’:
> /home/mcr2010/src/bzr/compiz.fix_1131864/src/window.cpp:3037:6: error:
> ‘shared_static_cast’ is not a member of ‘boost’
> boost::shared_static_cast <compiz::X11::PendingConfigureEvent> (p);
> ^
> /home/mcr2010/src/bzr/compiz.fix_1131864/src/window.cpp:3037:67: error:
> expected primary-expression before ‘>’ token
> boost::shared_static_cast <compiz::X11::PendingConfigureEvent> (p);
> ^
> At global scope:
> cc1plus: warning: unrecognized command line option "-Wno-unused-private-field"
> [enabled by default]
> cc1plus: warning: unrecognized command line option "-Wno-unused-private-field"
> [enabled by default]
> cc1plus: warning: unrecognized command line option "-Wno-unused-private-field"
> [enabled by default]
> [ 39%] make[2]: *** [src/CMakeFiles/compiz_core.dir/window.cpp.o] Error 1
> make[2]: *** Waiting for unfinished jobs....

Ah, thanks for that. Looks as though they are completely removed, I thought maybe the header file just changed.

https://bitbucket.org/osrf/gazebo/issue/581/boost-shared_-_cast-are-deprecated-removed

I've done a quick s/shared_static_cast/static_pointer_cast/

« Back to merge proposal