Code review comment for lp:~compiz-team/compiz/compiz.fix_1096455

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

On Wed, Jan 16, 2013 at 8:55 AM, Daniel van Vugt
<email address hidden> wrote:
> Review: Abstain
>
> Trying to make this build, I'm missing xig-0 for raring. Doesn't seem to exist for raring or quantal so I can't test it right now.
>
> Robert is working on updating the Xig PPA to support Q and R.
>

This doesn't use Xig, it uses xorg-gtest. It also doesn't require
either of them to build, just for the tests.

I've been thinking of dropping the Xig support for some time. Its a
really neat concept, but AFAICT its not really maintained, and there's
a large maintenance burden because it actually requires us to
re-implement support for the various bits of the protocol.

xorg-gtest gets us most of the way there. It doesn't allow us to truly
verify whats going on server side, but it does allow us to watch what
the server is saying.

xorg-gtest is a bit of a pain to build, but if I remember correctly it
was something like this:

1. sudo apt-get install libx11-dev libxi-dev xutils-dev xserver-xorg-dev
2. install xf86-video-dummy:
git://anongit.freedesktop.org/xorg/driver/xf86-video-dummy
3. install xorg-gtest: http://cgit.freedesktop.org/xorg/test/xorg-gtest/

You can try it out with that. Be aware that the xorg-gtest tests run a
little slowly (about 2 seconds per test), but thats because they start
a full xserver in the background.

> Abstain for now.
> --
> https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1096455/+merge/142847
> Your team Compiz Maintainers is subscribed to branch lp:compiz.

--
Sam Spilsbury

« Back to merge proposal