Code review comment for lp:~compiz-team/compiz/compiz.fix_1085591

Oh, could you get some more output for me?

Change the DEBUG #define to be 1 and run compiz --debug.

That will print out X errors as they occurr.
On Dec 4, 2012 12:32 PM, "Sam Spilsbury" <email address hidden> wrote:

> Hmm.
>
> Well in any case this does fix the problematic nature of the code. We are
> meant to check for errors upon taking SubstructureRedirectMask, and we
> don't do that properly.
>
> I'm suprised its still not working for you, it definitely fixed the
> problem here.
> On Dec 4, 2012 11:44 AM, "Daniel van Vugt" <email address hidden>
> wrote:
>
>> Review: Needs Fixing
>>
>> I still get bug 1085591 even with this branch. Seems like nothing is
>> fixed.
>>
>> 1. Start compiz
>> 2. Start another compiz --replace
>> Expected: Compiz is replaced
>> Observed: The old compiz is killed but the new one fails to start with:
>> compiz (core) - Error: Another window manager is already running on
>> screen: 0
>> --
>>
>> https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1085591/+merge/137524
>> Your team Compiz Maintainers is subscribed to branch lp:compiz.
>>
>