Code review comment for lp:~compiz-team/compiz/compiz.fix_1080989

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, all good. Maybe if you're reorganizing other peoples' code it would be best to add your own copyright below the existing ones. Because clearly the structure of the code is no longer the work of the original author(s).

Also I personally have a pet hate of:
    if (strlen (profile))
because it's just an inefficient way of writing:
    if (profile[0])
But that's just me.

review: Approve

« Back to merge proposal