Code review comment for lp:~compiz-team/compiz/compiz.fix_1080989

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

As for some other things:

Copyrights: no significant change, just extracting a header. Not worth it
IMO.

Test name: any ideas?

Separate bug: I think this is separate from the segfaults. The segfaults
are an issue with the gsettings back end, this one is about the global
profile selection being broken.
On 20/11/2012 5:34 PM, "Daniel van Vugt" <email address hidden>
wrote:

> Review: Needs Fixing
>
> I can't reproduce anything like bug 1080989 to verify. But I can see that
> this seems to fix bug 1070817. Can we make it bug 1070817 instead or are
> they separate?
>
> Also, the copyright header on new files should be one of your own :)
> --
>
> https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1080989/+merge/135065
> Your team Compiz Maintainers is subscribed to branch lp:compiz.
>

« Back to merge proposal