Code review comment for lp:~compiz-team/compiz/compiz.fix_1063617.7

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

1. As usual, I find it unreadable due to the long lines, from long identifiers and template use everywhere.

2. Can you find a better name for: class RequireSettingInterfaceRedirection ? There seems to be no (strong enough) noun really describing what an instance of such a thing is. How do I visualize a RequireSettingInterfaceRedirection in my model of the world? Is "redirection" the noun? Sounds more like an operation so would be a method of some other class.

review: Needs Information

« Back to merge proposal