Merge lp:~compiz-team/compiz/compiz.fix_1037164 into lp:compiz/0.9.9
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt |
Approved revision: | 3536 |
Merged at revision: | 3542 |
Proposed branch: | lp:~compiz-team/compiz/compiz.fix_1037164 |
Merge into: | lp:compiz/0.9.9 |
Diff against target: |
25 lines (+6/-2) 1 file modified
plugins/wall/src/wall.cpp (+6/-2) |
To merge this branch: | bzr merge lp:~compiz-team/compiz/compiz.fix_1037164 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Fixed: Clicking on semi-maximized windows in a different workspace fails to
switch to the correct workspace. (LP: #1037164)
Description of the change
Handle negative values returned by viewportForGeometry correclty.
Previously if we got a negative value for viewportForGeom
move to -n, -m, which would fail because checkDestination disallows those values.
checkDestination updated to accept negative values, because by default, we
actually pass negative values to it (since -dx, and -dy are negated before entry
into moveViewport). In any case, positive values are preferred, and the caller
was updated to provide positive values in case viewportForGeometry returns
negative values in order to avoid any unexpected behaviour.
In addition, if the window position needed to be changed, we'd be moving
the window by viewport-distance and not window distance due to a typo. That
was also fixed.
(LP: #1037164)
Not sure about the best way to autotest this. The only way I can think of would involve significant refactoring of calling code, which is no good.
PASSED: Continuous integration, rev:3535 jenkins. qa.ubuntu. com/job/ compiz- ci/339/ jenkins. qa.ubuntu. com/job/ compiz- ci/./build= pbuilder, distribution= quantal, flavor= amd64/339/ console
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild: jenkins. qa.ubuntu. com/job/ compiz- ci/339/ /rebuild/?
http://