Code review comment for lp:~compiz-team/compiz/compiz.fix_1024304.1

On Sun, Apr 28, 2013 at 12:18 AM, MC Return <email address hidden> wrote:
> Review: Approve
>
> Sam, I have one additional idea and suggestion for this though:
> We should ideally make this configurable via CCSM, so even users, who own hardware that supports GLX_EXT_buffer_age are not forced to use this OpenGL extension, should problems occur for them.
>
> Could you implement such an option ?
>
> Enable GLX_EXT_buffer_age Support (X)

I don't like the idea of options affecting the rendering system
generally. The system should pick the most optimal rendering path and
if it doesn't work then we fix it rather than having people disable
it.

EXT_b_a is straightforward to implement in a driver, any problems are
likely to be on the client implementation and not the driver.

>
> I am just choosing "Abstain" here, because Sam mentioned he would like to self-review this once again, but this is
> effectively an "Approve" from me... :)
> --
> https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1024304.1/+merge/160687
> You proposed lp:~compiz-team/compiz/compiz.fix_1024304.1 for merging.

--
Sam Spilsbury