Code review comment for lp:~compiz-team/compiz/compiz.fix_1012956

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also, I think it's technically wrong to be using an arithmetic OR on a bool:
  invisible |= w->destroyed ();

I'm not sure if that's a new C++ feature, but it shouldn't work normally.

It should probably be:
  bool invisible = w->invisible () || w->destroyed();

review: Needs Fixing

« Back to merge proposal