lp:~compiz-team/compiz/compiz.fix_1008020

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.8 at revision 3259

Daniel van Vugt: Approve on 2012-06-20

Robert Carr: Pending (testing) requested 2012-06-20

Tim Penhey: Pending requested 2012-06-20

Andrea Cimitan: Pending requested 2012-06-20

Diff: 255 lines (+55/-21)

9 files modified

include/core/abiversion.h (+1/-1)
include/core/screen.h (+2/-1)
include/core/window.h (+1/-0)
src/event.cpp (+10/-2)
src/privatescreen.h (+4/-2)
src/privatescreen/tests/test-privatescreen.cpp (+2/-1)
src/privatewindow.h (+1/-1)
src/screen.cpp (+24/-7)
src/window.cpp (+10/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #886605: Desktop, Launcher and menu bar still visible when screen locked	High	Fix Released
Bug #1008020: New windows can be stacked above panels if they are created just after an override redirect window is created	High	Fix Released

Link a bug report

Related blueprints

3245. By Sam Spilsbury on 2012-06-20

s/0/None/

3244. By Sam Spilsbury on 2012-06-20

Nicer style for screen.cpp createCompWindow

3243. By Sam Spilsbury on 2012-06-20

Added wrapper inline to get the Window

3242. By Sam Spilsbury on 2012-06-18

Return CompWindow *

3241. By Sam Spilsbury on 2012-06-13

Use .empty () instead of .size ()

3240. By Sam Spilsbury on 2012-06-13

Merge lp:compiz

3239. By Sam Spilsbury on 2012-06-03

Bump ABI

3238. By Sam Spilsbury on 2012-06-03

Don't insert the window into the server list above the window it was
created above.

The server list might have been modified by the time that we process the
create event, and as such there is a case where a window can be inserted
into the server list above another window and not at the top (the default
for where windows are created) if that window is pending a restack.

When updateAttributes is called later, putting it above the correct window
will silently fail, because it is already there in the server list, even
though a restack was never issued to put it there.

(LP: #1008020) (LP: #886605)

3237. By Daniel van Vugt on 2012-05-31

Improve the fix for LP: #1005569:
Calling CompOption::setName should not implicitly construct a new string
object every time, when the name is not changing.

This is also an alternative fix to the previous commit, but both together
don't hurt either.

3236. By Daniel van Vugt on 2012-05-30

Avoid constructing and destructing lots of strings on every single event,
which was wasting lots of CPU (LP: #1005569)