Code review comment for lp:~compiz-team/compiz/compiz.fix_1006335

On Fri, 1 Jun 2012, Daniel van Vugt wrote:

> Review: Needs Fixing
>
> That's a lot more complicated than the solution I had in mind, but if it works...
>
> Also, I recommend not changing unrelated logic like the location of:
> windowManager.removeDestroyed ();
> The change may be correct, but changing logic not related to the bug in question is best avoided.

Actually I changed it because we should be removing destroyed windows at
the end of every event processed. Without that change, we might never do
it.

Could you clarify what else needs fixing?

> --
> https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1006335/+merge/107953
> Your team Compiz Maintainers is requested to review the proposed merge of lp:~compiz-team/compiz/compiz.fix_1006335 into lp:compiz.
>