lp:~compiz-team/compiz/compiz.fix_1005569

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1005569: [callgrind] compiz spends ~25% of its time constructing/destructing strings in PrivateScreen::handleActionEvent

High

Fix Released

Link a bug report

Related blueprints

3235. By Sam Spilsbury on 2012-05-28

Added a small class to ensure that values get reset when we need them to

3234. By Sam Spilsbury on 2012-05-28

CompOption::setName was being called 8 times every single time
handleActionEvent was called, which was every event, including damage
events. That includes needless calls to malloc for what is effectively
a static option list

3233. By Sam Spilsbury on 2012-05-28

Don't read plugin.Initialized and test the value.

The python bindings indicate that all this does is return whether or not
the plugin is loaded, which is user-configurable and not deterministic.

      property Initialized:
          def __get__ (self):
              return bool (self.loaded)

As such, we shouldn't be testing that value

(LP: #1004848)

3232. By Sam Spilsbury on 2012-05-28

libcompizconfig's install () commands were still using the old includedir and
libdir variables rather than their libcompizconfig_* variants. (LP: #1005176)

3231. By Sam Spilsbury on 2012-05-28

Execute the cmake files separately to ensure that DESTDIR is respected.
(LP: #1005177)

The cmake preprocessor does substitution on install (CODE) at configure time
and not install time, when DESTDIR is actually set. In order to read it
correctly, we need to execute the cmake preprocessor in the install cmake
file itself, so that DESTDIR is set when the file is preprocessed.

3230. By Sam Spilsbury on 2012-05-28

Fixes warnings that happen on clang. Clang picked up a number of things by
default, including:

1. Memset by the size of a pointer rather than by the struct itself
2. inline functions in header files declared only
3. needless casting (although a leaked KWinAdapter is just insane, not sure
   how to fix that ..)
4. Unnecessary checks for < 0 with unsigned int
5. Member methods hiding virtual functions because they were never overridden
   correclty
6. Unused isAncestorTo in decor
7. ; after if statement with block proceeding in some places
8. Incrementing a bool

3229. By Sam Spilsbury on 2012-05-28

ASSERT_EQ has a NULL expectation that doesn't work on gcc 4.7 so use
EXPECT_FALSE instead

3228. By Sam Spilsbury on 2012-05-28

Don't set_target_properties on a target that might not exist (LP: #1005008)

3227. By Sam Spilsbury on 2012-05-28

Don't allow windows which we weren't even tracking as decoratable to become
decorated if they try and change their hints.

For example: unity-2d-panel shouldn't become "decorated" as normal when it
tries to change its decoration hints.

Fixes bare type window decorations being added to the draw queue.

(LP: #963794)

3226. By Daniel van Vugt on 2012-05-28

Change the mouse pointer while dragging windows in expo. Just like the
ubuntu branches do. (LP: #987647)

(This fix was reviewed and approved a month ago but couldn't be merged to
 lp:compiz-expo-plugin due to bzr corruption)