Created by Sam Spilsbury on 2012-09-18 and last modified on 2012-09-18
Get this branch:
bzr branch lp:~compiz-team/compiz/compiz.find-top-level-window-server-frame
Members of Compiz Maintainers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Compiz Maintainers

Recent revisions

3381. By Sam Spilsbury on 2012-09-18

When calling findTopLevelWindow we're interested in any windows that could
be pending a reparent too, as we could call it relative to their pending frame

3380. By Sam Spilsbury on 2012-09-17

Actually provide the hint

3379. By Sam Spilsbury on 2012-09-17

Bump ABI

3378. By Sam Spilsbury on 2012-09-17

Check that pixmaps which aren't managed by us actually exist before binding.

It was possible for there to be a race condition for a pixmap to become
invalid on the server side if the client which did have control over thier
lifecycle freed them before we were done with them or disconnected. Drivers
have normally handled this condition by reading the contents of the undefined
memory directly without an error, however drivers such as LLVMpipe will
effectively dereference an invalid pointer and crash when you do this.


compiz crashed with SIGSEGV in memmove() from drisw_update_tex_buffer() from dri_set_tex_buffer2() from drisw_bind_tex_image() from __glXBindTexImageEXT() from TfpTexture::enable()

Most of the time we don't need to employ this check. Its only when we know
that we don't control the lifecycle of a pixmap that race conditions
such as these can occurr.

3377. By Sam Spilsbury on 2012-09-17

Make the tests pass

3376. By Sam Spilsbury on 2012-09-17

Walking skeleton for glx tfp bind code, failing tests:

[ FAILED ] CompizOpenGLGLXTextureFromPixmapBindTest.TestTakesServerGrab
[ FAILED ] CompizOpenGLGLXTextureFromPixmapBindTest.TestNoCallToCheckValidityIfInternalAndImmediateBind
[ FAILED ] CompizOpenGLGLXTextureFromPixmapBindTest.TestCheckValidityIfExternalNoBindIfInvalid
[ FAILED ] CompizOpenGLGLXTextureFromPixmapBindTest.TestCheckValidityIfExternalBindIfValid

3375. By Iven Hsu on 2012-09-15

Fix (LP: #1050752). https://bugs.launchpad.net/compiz/+bug/1050752

In the initializing of the plugin, it should not only start handling the events, but also enable GL paint.. Fixes: https://bugs.launchpad.net/bugs/1050752. Approved by Sam Spilsbury.

3374. By Daniel van Vugt on 2012-09-14

Avoid a NULL dereference and give a useful error message instead.
(LP: #944653). Fixes: https://bugs.launchpad.net/bugs/944653. Approved by Sam Spilsbury, jenkins.

3373. By Ɓukasz Zemczak on 2012-09-13

It seems that with USE_GCONF disabled, the gsettings xslt files are not installed. I *think* this might help?. Fixes: . Approved by Brandon Schaefer, jenkins.

3372. By Daniel van Vugt on 2012-09-13

Ensure window decorations always get rendered after the window, not before.
This is how it was in compiz 0.9.7, and is required in order to resolve
unity panel shadow bug 1045705.. Fixes: . Approved by jenkins, Sam Spilsbury.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.