Manual regression testing, including under valgrind, all seems OK.
However, I think it's a terrible idea to make an 8584 line proposal. There will almost certainly be regressions neither of us have found yet.
I also think it's a bad idea to rewrite a large chunk of (mature-ish) code from procedural to object-oriented, just to use Google Test/Mock. But I also won't block this proposal because I'm not about to invest the time to prototype a better alternative. And I don't have enough understanding of compizconfig to know where to begin.
Manual regression testing, including under valgrind, all seems OK.
However, I think it's a terrible idea to make an 8584 line proposal. There will almost certainly be regressions neither of us have found yet.
I also think it's a bad idea to rewrite a large chunk of (mature-ish) code from procedural to object-oriented, just to use Google Test/Mock. But I also won't block this proposal because I'm not about to invest the time to prototype a better alternative. And I don't have enough understanding of compizconfig to know where to begin.