Merge compiz:mitya57/xz-tarballs into compiz:master

Proposed by Dmitry Shachnev
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 2ea8a694ff9d644b4a9df49d5a34cc41327130f3
Merged at revision: 2ea8a694ff9d644b4a9df49d5a34cc41327130f3
Proposed branch: compiz:mitya57/xz-tarballs
Merge into: compiz:master
Diff against target: 44 lines (+7/-6)
1 file modified
cmake/CompizCommon.cmake (+7/-6)
Reviewer Review Type Date Requested Status
Alberts Muktupāvels Approve
Marco Trevisan (Treviño) Pending
Compiz Maintainers Pending
Review via email: mp+363208@code.launchpad.net

Description of the change

More fixes related to tarballs generation.

- There are no advantages of .tar.bz2 over .tar.xz. The latter has higher compression ratios and faster decompression. It can be slower in compression but that does not matter for tarballs, as they are only compressed once. So let’s switch to .tar.xz.

- Git does not support .tar.xz out of the box (it only supports .tar.gz), so a config is needed. I had that locally so I did not notice it in the previous commit.

- Update release commands to work with .tar.xz tarballs.

To post a comment you must log in.
Revision history for this message
Alberts Muktupāvels (muktupavels) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/cmake/CompizCommon.cmake b/cmake/CompizCommon.cmake
index e48da17..8c71cac 100644
--- a/cmake/CompizCommon.cmake
+++ b/cmake/CompizCommon.cmake
@@ -293,7 +293,8 @@ endfunction ()
293macro (compiz_add_git_dist)293macro (compiz_add_git_dist)
294294
295 add_custom_target (dist295 add_custom_target (dist
296 COMMAND git archive -o ${CMAKE_BINARY_DIR}/${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz --prefix=${CMAKE_PROJECT_NAME}-${VERSION}/ HEAD296 COMMAND git config tar.tar.xz.command "xz -c"
297 && git archive -o ${CMAKE_BINARY_DIR}/${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz --prefix=${CMAKE_PROJECT_NAME}-${VERSION}/ HEAD
297 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})298 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})
298299
299endmacro ()300endmacro ()
@@ -301,9 +302,9 @@ endmacro ()
301macro (compiz_add_distcheck)302macro (compiz_add_distcheck)
302 add_custom_target (distcheck 303 add_custom_target (distcheck
303 COMMAND mkdir -p ${CMAKE_BINARY_DIR}/dist-build304 COMMAND mkdir -p ${CMAKE_BINARY_DIR}/dist-build
304 && cp ${CMAKE_BINARY_DIR}/${CMAKE_PROJECT_NAME}-${VERSION}.tar.bz2 ${CMAKE_BINARY_DIR}/dist-build305 && cp ${CMAKE_BINARY_DIR}/${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz ${CMAKE_BINARY_DIR}/dist-build
305 && cd ${CMAKE_BINARY_DIR}/dist-build306 && cd ${CMAKE_BINARY_DIR}/dist-build
306 && tar xvf ${CMAKE_BINARY_DIR}/dist-build/${CMAKE_PROJECT_NAME}-${VERSION}.tar.bz2307 && tar xvf ${CMAKE_BINARY_DIR}/dist-build/${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz
307 && mkdir -p ${CMAKE_BINARY_DIR}/dist-build/${CMAKE_PROJECT_NAME}-${VERSION}/build308 && mkdir -p ${CMAKE_BINARY_DIR}/dist-build/${CMAKE_PROJECT_NAME}-${VERSION}/build
308 && cd ${CMAKE_BINARY_DIR}/dist-build/${CMAKE_PROJECT_NAME}-${VERSION}/build309 && cd ${CMAKE_BINARY_DIR}/dist-build/${CMAKE_PROJECT_NAME}-${VERSION}/build
309 && cmake -DCMAKE_INSTALL_PREFIX=${CMAKE_BINARY_DIR}/dist-build/buildroot -DCOMPIZ_PLUGIN_INSTALL_TYPE='package' .. -DCMAKE_MODULE_PATH=/usr/share/cmake310 && cmake -DCMAKE_INSTALL_PREFIX=${CMAKE_BINARY_DIR}/dist-build/buildroot -DCOMPIZ_PLUGIN_INSTALL_TYPE='package' .. -DCMAKE_MODULE_PATH=/usr/share/cmake
@@ -338,15 +339,15 @@ macro (compiz_add_release_signoff)
338 add_custom_target (release-version-bump)339 add_custom_target (release-version-bump)
339340
340 add_custom_target (release-sign-tarballs341 add_custom_target (release-sign-tarballs
341 COMMAND gpg --armor --sign --detach-sig ${CMAKE_PROJECT_NAME}-${VERSION}.tar.bz2342 COMMAND gpg --armor --sign --detach-sig ${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz
342 COMMENT "Signing tarball"343 COMMENT "Signing tarball"
343 WORKING_DIRECTORY ${CMAKE_BINARY_DIR})344 WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
344 add_custom_target (release-sha1-tarballs345 add_custom_target (release-sha1-tarballs
345 COMMAND sha1sum ${CMAKE_PROJECT_NAME}-${VERSION}.tar.bz2 > ${CMAKE_PROJECT_NAME}-${VERSION}.tar.bz2.sha1346 COMMAND sha1sum ${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz > ${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz.sha1
346 COMMENT "SHA1Summing tarball"347 COMMENT "SHA1Summing tarball"
347 WORKING_DIRECTORY ${CMAKE_BINARY_DIR})348 WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
348 add_custom_target (release-sign-sha1-tarballs349 add_custom_target (release-sign-sha1-tarballs
349 COMMAND gpg --armor --sign --detach-sig ${CMAKE_PROJECT_NAME}-${VERSION}.tar.bz2.sha1350 COMMAND gpg --armor --sign --detach-sig ${CMAKE_PROJECT_NAME}-${VERSION}.tar.xz.sha1
350 COMMENT "Signing SHA1Sum checksum"351 COMMENT "Signing SHA1Sum checksum"
351 WORKING_DIRECTORY ${CMAKE_BINARY_DIR})352 WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
352353

Subscribers

People subscribed via source and target branches