Code review comment for lp:~compiz-team/compiz-core/compiz-core.fix_883102

Revision history for this message
Thomas Voß (thomas-voss) wrote :

+1 for Jussi's remarks.

Regarding Google Test: It is recommended in [*] that Google Test is distributed together with the respective project. It provides a simple CMake setup that allows for adding it in by means of add_subdirectory in compiz' CMake setup.

[*] http://code.google.com/p/googletest/wiki/V1_6_Primer#Setting_up_a_New_Test_Project

review: Needs Fixing

« Back to merge proposal