Code review comment for lp:~compiz-team/compiz-core/compiz-core.fix_883102
Revision history for this message
| Tim Penhey (thumper) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
I find the string test remarkably hard to follow. Have you considered using google-test and google-mock for the testing framework?
The CMake stuff is way over my understanding, and I can't comfortably review the code.
A +1 for removing compiz.h, but is this used in unity at all?