Merge lp:~compiz-team/compiz-compizconfig-gconf/compiz-compizconfig-gconf.fix_802373 into lp:compiz-compizconfig-gconf/trunk

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 159
Proposed branch: lp:~compiz-team/compiz-compizconfig-gconf/compiz-compizconfig-gconf.fix_802373
Merge into: lp:compiz-compizconfig-gconf/trunk
Diff against target: 58 lines (+26/-1)
1 file modified
src/gconf.c (+26/-1)
To merge this branch: bzr merge lp:~compiz-team/compiz-compizconfig-gconf/compiz-compizconfig-gconf.fix_802373
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Sam Spilsbury Pending
Review via email: mp+65940@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks good, approved!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/gconf.c'
--- src/gconf.c 2010-12-10 13:52:54 +0000
+++ src/gconf.c 2011-06-27 07:24:33 +0000
@@ -98,6 +98,7 @@
98 OptionInt,98 OptionInt,
99 OptionBool,99 OptionBool,
100 OptionKey,100 OptionKey,
101 OptionBell,
101 OptionString,102 OptionString,
102 OptionSpecial,103 OptionSpecial,
103} SpecialOptionType;104} SpecialOptionType;
@@ -167,7 +168,7 @@
167 METACITY "/general/resize_with_right_button", OptionSpecial},168 METACITY "/general/resize_with_right_button", OptionSpecial},
168169
169 {"visual_bell", "fade", TRUE,170 {"visual_bell", "fade", TRUE,
170 METACITY "/general/visual_bell", OptionBool},171 METACITY "/general/visual_bell", OptionBell},
171 {"fullscreen_visual_bell", "fade", TRUE,172 {"fullscreen_visual_bell", "fade", TRUE,
172 METACITY "/general/visual_bell_type", OptionSpecial},173 METACITY "/general/visual_bell_type", OptionSpecial},
173174
@@ -1001,6 +1002,16 @@
1001 ret = TRUE;1002 ret = TRUE;
1002 }1003 }
1003 break;1004 break;
1005 case OptionBell:
1006 if (gconfValue->type == GCONF_VALUE_BOOL)
1007 {
1008 gboolean value;
1009
1010 value = gconf_value_get_bool (gconfValue);
1011 ccsSetBell (setting, value ? TRUE : FALSE);
1012 ret = TRUE;
1013 }
1014 break;
1004 case OptionString:1015 case OptionString:
1005 if (gconfValue->type == GCONF_VALUE_STRING)1016 if (gconfValue->type == GCONF_VALUE_STRING)
1006 {1017 {
@@ -1518,6 +1529,20 @@
1518 newValue, NULL);1529 newValue, NULL);
1519 }1530 }
1520 break;1531 break;
1532 case OptionBell:
1533 {
1534 Bool newValue;
1535 gboolean currentValue;
1536 if (!ccsGetBell (setting, &newValue))
1537 break;
1538 currentValue = gconf_client_get_bool (client, optionName, &err);
1539
1540 if (!err && ((currentValue && !newValue) ||
1541 (!currentValue && newValue)))
1542 gconf_client_set_bool (client, specialOptions[index].gnomeName,
1543 newValue, NULL);
1544 }
1545 break;
1521 case OptionString:1546 case OptionString:
1522 {1547 {
1523 char *newValue;1548 char *newValue;

Subscribers

People subscribed via source and target branches