Merge lp:~colin-king/ecryptfs/ecryptfs-spelling-fixes into lp:ecryptfs

Proposed by Colin Ian King
Status: Merged
Merged at revision: 822
Proposed branch: lp:~colin-king/ecryptfs/ecryptfs-spelling-fixes
Merge into: lp:ecryptfs
Diff against target: 102 lines (+9/-9)
6 files modified
doc/beginners_guide/ecryptfs_beginners_guide.tex (+1/-1)
doc/design_doc/ecryptfs_design_doc_v0_1.tex (+2/-2)
doc/design_doc/ecryptfs_design_doc_v0_2.tex (+2/-2)
doc/ecryptfs-pkcs11-helper-doc.txt (+1/-1)
doc/manpage/ecryptfs.7 (+2/-2)
tests/README (+1/-1)
To merge this branch: bzr merge lp:~colin-king/ecryptfs/ecryptfs-spelling-fixes
Reviewer Review Type Date Requested Status
Tyler Hicks Approve
Review via email: mp+196332@code.launchpad.net

Description of the change

Some minor spelling mistake fixes. Nothing too exciting really.

To post a comment you must log in.
Revision history for this message
Tyler Hicks (tyhicks) wrote :

Looks good. Please push it to trunk. Thanks!

review: Approve
Revision history for this message
Colin Ian King (colin-king) wrote :

On 22/11/13 17:32, Tyler Hicks wrote:
> Review: Approve
>
> Looks good. Please push it to trunk. Thanks!
>

My bzr foo is lame, in fact I've never done that before (I mainly use
git). How do I do that w/o messing up the world?

Colin

Revision history for this message
Tyler Hicks (tyhicks) wrote :

On 2013-11-22 17:48:15, Colin King wrote:
> On 22/11/13 17:32, Tyler Hicks wrote:
> > Review: Approve
> >
> > Looks good. Please push it to trunk. Thanks!
> >
>
> My bzr foo is lame, in fact I've never done that before (I mainly use
> git). How do I do that w/o messing up the world?

If your bzr branch is simply trunk + your patches, then
`bzr push lp:ecryptfs` will do.

If your bzr branch is an older version of trunk + your patches, I really
don't know what the best way is (this is where I miss my git workflow).
You can checkout trunk in a new branch, `bzr branch lp:ecryptfs`, and
then cd into the new branch and merge in your feature branch with
`bzr merge ../path/to/feature/branch`. I don't really like doing that
because it ends up hiding all of the commits behind a single merge
commit. If my feature branch is behind trunk, I usually manually
cherry-pick the commits in my feature branch to a fresh checkout of
trunk.

Hopefully paragraph 1 describes your situation. Don't mess with it for
too long, though. If you're having any trouble at all, kick it back over
to me and I'll pull in your changes.

Revision history for this message
Colin Ian King (colin-king) wrote :

On 22/11/13 18:03, Tyler Hicks wrote:
> On 2013-11-22 17:48:15, Colin King wrote:
>> On 22/11/13 17:32, Tyler Hicks wrote:
>>> Review: Approve
>>>
>>> Looks good. Please push it to trunk. Thanks!
>>>
>>
>> My bzr foo is lame, in fact I've never done that before (I mainly use
>> git). How do I do that w/o messing up the world?
>
> If your bzr branch is simply trunk + your patches, then
> `bzr push lp:ecryptfs` will do.

Thanks, done.
>
> If your bzr branch is an older version of trunk + your patches, I really
> don't know what the best way is (this is where I miss my git workflow).
> You can checkout trunk in a new branch, `bzr branch lp:ecryptfs`, and
> then cd into the new branch and merge in your feature branch with
> `bzr merge ../path/to/feature/branch`. I don't really like doing that
> because it ends up hiding all of the commits behind a single merge
> commit. If my feature branch is behind trunk, I usually manually
> cherry-pick the commits in my feature branch to a fresh checkout of
> trunk.
>
> Hopefully paragraph 1 describes your situation. Don't mess with it for
> too long, though. If you're having any trouble at all, kick it back over
> to me and I'll pull in your changes.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doc/beginners_guide/ecryptfs_beginners_guide.tex'
--- doc/beginners_guide/ecryptfs_beginners_guide.tex 2009-02-03 08:50:36 +0000
+++ doc/beginners_guide/ecryptfs_beginners_guide.tex 2013-11-22 17:26:11 +0000
@@ -35,7 +35,7 @@
35\section*{Mounting eCryptfs}35\section*{Mounting eCryptfs}
3636
37eCryptfs is currently under development, with future versions being37eCryptfs is currently under development, with future versions being
38backwards compatable. Currently, eCryptfs is in version 0.1, and you can38backwards compatible. Currently, eCryptfs is in version 0.1, and you can
39read about the various ways eCryptfs can be mounted in the appropriate39read about the various ways eCryptfs can be mounted in the appropriate
40subsection.40subsection.
4141
4242
=== modified file 'doc/design_doc/ecryptfs_design_doc_v0_1.tex'
--- doc/design_doc/ecryptfs_design_doc_v0_1.tex 2009-02-03 08:50:36 +0000
+++ doc/design_doc/ecryptfs_design_doc_v0_1.tex 2013-11-22 17:26:11 +0000
@@ -243,7 +243,7 @@
243after the file is initially created. When a file is no longer being243after the file is initially created. When a file is no longer being
244accessed, the kernel VFS frees its associated file, dentry, and inode244accessed, the kernel VFS frees its associated file, dentry, and inode
245objects according to the standard resource deallocation process in the245objects according to the standard resource deallocation process in the
246VFS; eCryptfs does not perform any futher cryptographic operations on246VFS; eCryptfs does not perform any further cryptographic operations on
247the file.247the file.
248248
249\section{Cryptographic Properties}249\section{Cryptographic Properties}
@@ -474,4 +474,4 @@
474474
475(End of Document.)475(End of Document.)
476476
477\end{document}
478\ No newline at end of file477\ No newline at end of file
478\end{document}
479479
=== modified file 'doc/design_doc/ecryptfs_design_doc_v0_2.tex'
--- doc/design_doc/ecryptfs_design_doc_v0_2.tex 2012-11-02 14:31:32 +0000
+++ doc/design_doc/ecryptfs_design_doc_v0_2.tex 2013-11-22 17:26:11 +0000
@@ -274,7 +274,7 @@
274kernel crypto API, and the encrypted page is written out to the lower274kernel crypto API, and the encrypted page is written out to the lower
275file.275file.
276276
277If HMAC verification was enabled as a mount paramter, then... TODO277If HMAC verification was enabled as a mount parameter, then... TODO
278278
279\subsubsection{File Truncation}279\subsubsection{File Truncation}
280280
@@ -471,7 +471,7 @@
471maintain their own policy, and are unaffected by this mount option.471maintain their own policy, and are unaffected by this mount option.
472472
473eCryptfs calculates HMAC values over a fixed number $L$ of extents473eCryptfs calculates HMAC values over a fixed number $L$ of extents
474and stores those values in headers preceeding the groups of extents; these474and stores those values in headers preceding the groups of extents; these
475are the the 2nd level HMAC headers. eCryptfs also calculates HMAC values475are the the 2nd level HMAC headers. eCryptfs also calculates HMAC values
476over the 2nd level HMAC headers and stores them in the 1st level HMAC476over the 2nd level HMAC headers and stores them in the 1st level HMAC
477headers. Finally, eCryptfs calculates a root HMAC value over all of477headers. Finally, eCryptfs calculates a root HMAC value over all of
478478
=== modified file 'doc/ecryptfs-pkcs11-helper-doc.txt'
--- doc/ecryptfs-pkcs11-helper-doc.txt 2009-02-03 08:50:36 +0000
+++ doc/ecryptfs-pkcs11-helper-doc.txt 2013-11-22 17:26:11 +0000
@@ -53,7 +53,7 @@
53 key Attributes:53 key Attributes:
54 id (String)54 id (String)
55 PKCS#11 serialized object id, this object id can be55 PKCS#11 serialized object id, this object id can be
56 aquired using ecryptfs-manager, the default value of56 acquired using ecryptfs-manager, the default value of
57 this field is a list of "DN (serial) [serialized id]".57 this field is a list of "DN (serial) [serialized id]".
5858
59 x509file (String)59 x509file (String)
6060
=== modified file 'doc/manpage/ecryptfs.7'
--- doc/manpage/ecryptfs.7 2013-03-11 05:54:36 +0000
+++ doc/manpage/ecryptfs.7 2013-11-22 17:26:11 +0000
@@ -67,7 +67,7 @@
67The actual password is passphrase. Since the password is visible to utilities (like ps under Unix) this form should only be used where security is not important.67The actual password is passphrase. Since the password is visible to utilities (like ps under Unix) this form should only be used where security is not important.
68.TP68.TP
69.B passphrase_passwd_file=(filename)69.B passphrase_passwd_file=(filename)
70The password should be specified in a file with passwd=(passphrase). It is highly reccomended that the file be stored on a secure medium such as a personal usb key.70The password should be specified in a file with passwd=(passphrase). It is highly recommended that the file be stored on a secure medium such as a personal usb key.
71.TP71.TP
72.B passphrase_passwd_fd=(file descriptor)72.B passphrase_passwd_fd=(file descriptor)
73The password is specified through the specified file descriptor.73The password is specified through the specified file descriptor.
@@ -79,7 +79,7 @@
79The filename should be the filename of a file containing an RSA SSL key.79The filename should be the filename of a file containing an RSA SSL key.
80.TP80.TP
81.B openssl_passwd_file=(filename)81.B openssl_passwd_file=(filename)
82The password should be specified in a file with openssl_passwd=(openssl-password). It is highly reccomended that the file be stored on a secure medium such as a personal usb key.82The password should be specified in a file with openssl_passwd=(openssl-password). It is highly recommended that the file be stored on a secure medium such as a personal usb key.
83.TP83.TP
84.B openssl_passwd_fd=(file descriptor)84.B openssl_passwd_fd=(file descriptor)
85The password is specified through the specified file descriptor.85The password is specified through the specified file descriptor.
8686
=== modified file 'tests/README'
--- tests/README 2012-11-02 23:20:18 +0000
+++ tests/README 2013-11-22 17:26:11 +0000
@@ -99,7 +99,7 @@
9999
100 8) Create a new file, inside that directory, called test.c and implement the100 8) Create a new file, inside that directory, called test.c and implement the
101 test case in the new file. Be sure to add a header, including the GPLv2101 test case in the new file. Be sure to add a header, including the GPLv2
102 text, similiar to what is in the example test script that was modified in102 text, similar to what is in the example test script that was modified in
103 step 3).103 step 3).
104104
105 9) Update the test script (mmap-close.sh) to call the test binary after the105 9) Update the test script (mmap-close.sh) to call the test binary after the

Subscribers

People subscribed via source and target branches