Merge lp:~colin-king/ecryptfs/ecryptfs-spelling-fixes into lp:ecryptfs

Proposed by Colin Ian King
Status: Merged
Merged at revision: 822
Proposed branch: lp:~colin-king/ecryptfs/ecryptfs-spelling-fixes
Merge into: lp:ecryptfs
Diff against target: 102 lines (+9/-9)
6 files modified
doc/beginners_guide/ecryptfs_beginners_guide.tex (+1/-1)
doc/design_doc/ecryptfs_design_doc_v0_1.tex (+2/-2)
doc/design_doc/ecryptfs_design_doc_v0_2.tex (+2/-2)
doc/ecryptfs-pkcs11-helper-doc.txt (+1/-1)
doc/manpage/ecryptfs.7 (+2/-2)
tests/README (+1/-1)
To merge this branch: bzr merge lp:~colin-king/ecryptfs/ecryptfs-spelling-fixes
Reviewer Review Type Date Requested Status
Tyler Hicks Approve
Review via email: mp+196332@code.launchpad.net

Description of the change

Some minor spelling mistake fixes. Nothing too exciting really.

To post a comment you must log in.
Revision history for this message
Tyler Hicks (tyhicks) wrote :

Looks good. Please push it to trunk. Thanks!

review: Approve
Revision history for this message
Colin Ian King (colin-king) wrote :

On 22/11/13 17:32, Tyler Hicks wrote:
> Review: Approve
>
> Looks good. Please push it to trunk. Thanks!
>

My bzr foo is lame, in fact I've never done that before (I mainly use
git). How do I do that w/o messing up the world?

Colin

Revision history for this message
Tyler Hicks (tyhicks) wrote :

On 2013-11-22 17:48:15, Colin King wrote:
> On 22/11/13 17:32, Tyler Hicks wrote:
> > Review: Approve
> >
> > Looks good. Please push it to trunk. Thanks!
> >
>
> My bzr foo is lame, in fact I've never done that before (I mainly use
> git). How do I do that w/o messing up the world?

If your bzr branch is simply trunk + your patches, then
`bzr push lp:ecryptfs` will do.

If your bzr branch is an older version of trunk + your patches, I really
don't know what the best way is (this is where I miss my git workflow).
You can checkout trunk in a new branch, `bzr branch lp:ecryptfs`, and
then cd into the new branch and merge in your feature branch with
`bzr merge ../path/to/feature/branch`. I don't really like doing that
because it ends up hiding all of the commits behind a single merge
commit. If my feature branch is behind trunk, I usually manually
cherry-pick the commits in my feature branch to a fresh checkout of
trunk.

Hopefully paragraph 1 describes your situation. Don't mess with it for
too long, though. If you're having any trouble at all, kick it back over
to me and I'll pull in your changes.

Revision history for this message
Colin Ian King (colin-king) wrote :

On 22/11/13 18:03, Tyler Hicks wrote:
> On 2013-11-22 17:48:15, Colin King wrote:
>> On 22/11/13 17:32, Tyler Hicks wrote:
>>> Review: Approve
>>>
>>> Looks good. Please push it to trunk. Thanks!
>>>
>>
>> My bzr foo is lame, in fact I've never done that before (I mainly use
>> git). How do I do that w/o messing up the world?
>
> If your bzr branch is simply trunk + your patches, then
> `bzr push lp:ecryptfs` will do.

Thanks, done.
>
> If your bzr branch is an older version of trunk + your patches, I really
> don't know what the best way is (this is where I miss my git workflow).
> You can checkout trunk in a new branch, `bzr branch lp:ecryptfs`, and
> then cd into the new branch and merge in your feature branch with
> `bzr merge ../path/to/feature/branch`. I don't really like doing that
> because it ends up hiding all of the commits behind a single merge
> commit. If my feature branch is behind trunk, I usually manually
> cherry-pick the commits in my feature branch to a fresh checkout of
> trunk.
>
> Hopefully paragraph 1 describes your situation. Don't mess with it for
> too long, though. If you're having any trouble at all, kick it back over
> to me and I'll pull in your changes.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/beginners_guide/ecryptfs_beginners_guide.tex'
2--- doc/beginners_guide/ecryptfs_beginners_guide.tex 2009-02-03 08:50:36 +0000
3+++ doc/beginners_guide/ecryptfs_beginners_guide.tex 2013-11-22 17:26:11 +0000
4@@ -35,7 +35,7 @@
5 \section*{Mounting eCryptfs}
6
7 eCryptfs is currently under development, with future versions being
8-backwards compatable. Currently, eCryptfs is in version 0.1, and you can
9+backwards compatible. Currently, eCryptfs is in version 0.1, and you can
10 read about the various ways eCryptfs can be mounted in the appropriate
11 subsection.
12
13
14=== modified file 'doc/design_doc/ecryptfs_design_doc_v0_1.tex'
15--- doc/design_doc/ecryptfs_design_doc_v0_1.tex 2009-02-03 08:50:36 +0000
16+++ doc/design_doc/ecryptfs_design_doc_v0_1.tex 2013-11-22 17:26:11 +0000
17@@ -243,7 +243,7 @@
18 after the file is initially created. When a file is no longer being
19 accessed, the kernel VFS frees its associated file, dentry, and inode
20 objects according to the standard resource deallocation process in the
21-VFS; eCryptfs does not perform any futher cryptographic operations on
22+VFS; eCryptfs does not perform any further cryptographic operations on
23 the file.
24
25 \section{Cryptographic Properties}
26@@ -474,4 +474,4 @@
27
28 (End of Document.)
29
30-\end{document}
31\ No newline at end of file
32+\end{document}
33
34=== modified file 'doc/design_doc/ecryptfs_design_doc_v0_2.tex'
35--- doc/design_doc/ecryptfs_design_doc_v0_2.tex 2012-11-02 14:31:32 +0000
36+++ doc/design_doc/ecryptfs_design_doc_v0_2.tex 2013-11-22 17:26:11 +0000
37@@ -274,7 +274,7 @@
38 kernel crypto API, and the encrypted page is written out to the lower
39 file.
40
41-If HMAC verification was enabled as a mount paramter, then... TODO
42+If HMAC verification was enabled as a mount parameter, then... TODO
43
44 \subsubsection{File Truncation}
45
46@@ -471,7 +471,7 @@
47 maintain their own policy, and are unaffected by this mount option.
48
49 eCryptfs calculates HMAC values over a fixed number $L$ of extents
50-and stores those values in headers preceeding the groups of extents; these
51+and stores those values in headers preceding the groups of extents; these
52 are the the 2nd level HMAC headers. eCryptfs also calculates HMAC values
53 over the 2nd level HMAC headers and stores them in the 1st level HMAC
54 headers. Finally, eCryptfs calculates a root HMAC value over all of
55
56=== modified file 'doc/ecryptfs-pkcs11-helper-doc.txt'
57--- doc/ecryptfs-pkcs11-helper-doc.txt 2009-02-03 08:50:36 +0000
58+++ doc/ecryptfs-pkcs11-helper-doc.txt 2013-11-22 17:26:11 +0000
59@@ -53,7 +53,7 @@
60 key Attributes:
61 id (String)
62 PKCS#11 serialized object id, this object id can be
63- aquired using ecryptfs-manager, the default value of
64+ acquired using ecryptfs-manager, the default value of
65 this field is a list of "DN (serial) [serialized id]".
66
67 x509file (String)
68
69=== modified file 'doc/manpage/ecryptfs.7'
70--- doc/manpage/ecryptfs.7 2013-03-11 05:54:36 +0000
71+++ doc/manpage/ecryptfs.7 2013-11-22 17:26:11 +0000
72@@ -67,7 +67,7 @@
73 The actual password is passphrase. Since the password is visible to utilities (like ps under Unix) this form should only be used where security is not important.
74 .TP
75 .B passphrase_passwd_file=(filename)
76-The password should be specified in a file with passwd=(passphrase). It is highly reccomended that the file be stored on a secure medium such as a personal usb key.
77+The password should be specified in a file with passwd=(passphrase). It is highly recommended that the file be stored on a secure medium such as a personal usb key.
78 .TP
79 .B passphrase_passwd_fd=(file descriptor)
80 The password is specified through the specified file descriptor.
81@@ -79,7 +79,7 @@
82 The filename should be the filename of a file containing an RSA SSL key.
83 .TP
84 .B openssl_passwd_file=(filename)
85-The password should be specified in a file with openssl_passwd=(openssl-password). It is highly reccomended that the file be stored on a secure medium such as a personal usb key.
86+The password should be specified in a file with openssl_passwd=(openssl-password). It is highly recommended that the file be stored on a secure medium such as a personal usb key.
87 .TP
88 .B openssl_passwd_fd=(file descriptor)
89 The password is specified through the specified file descriptor.
90
91=== modified file 'tests/README'
92--- tests/README 2012-11-02 23:20:18 +0000
93+++ tests/README 2013-11-22 17:26:11 +0000
94@@ -99,7 +99,7 @@
95
96 8) Create a new file, inside that directory, called test.c and implement the
97 test case in the new file. Be sure to add a header, including the GPLv2
98- text, similiar to what is in the example test script that was modified in
99+ text, similar to what is in the example test script that was modified in
100 step 3).
101
102 9) Update the test script (mmap-close.sh) to call the test binary after the

Subscribers

People subscribed via source and target branches