Code review comment for ~codyshepherd/cloud-images/+git/aws-eks-website:update/1-11/20190814

Revision history for this message
Francis Ginther (fginther) wrote :

AMI updates look good, the update script also looks good. I found one issue with the rendering of the 1.12/1.11 buttons. Both chrome and firefox now render these smooshed together when there was a gap before. The only change in the relevant code is the layout. I was able to get nearly identical results with the following:

$ git diff
diff --git a/index.html b/index.html
index f714f03..079140e 100644
--- a/index.html
+++ b/index.html
@@ -72,11 +72,11 @@

       .p-inline-list {
         display: inline;
- margin-left: 0.5rem;
+ margin-left: 0.25rem;
       }

       .p-inline-list__item {
- margin-right: 0;
+ margin-right: 0.25rem;
       }

       .p-navigation a,

I don't know if that's the best way to solve the problem, but it works in both chrome and firefox. I do think the buttons should be separated, but if you want to address this with a follow-up MP instead of here, I'd be ok with that.

review: Needs Fixing

« Back to merge proposal