Merge lp:~codygarver/switchboard/no-cheese-please into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Cody Garver
Status: Merged
Approved by: Cody Garver
Approved revision: 546
Merged at revision: 551
Proposed branch: lp:~codygarver/switchboard/no-cheese-please
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 54 lines (+4/-9)
2 files modified
CMakeLists.txt (+2/-2)
src/Switchboard.vala (+2/-7)
To merge this branch: bzr merge lp:~codygarver/switchboard/no-cheese-please
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Cody Garver (community) Abstain
Review via email: mp+255616@code.launchpad.net

Commit message

Drop cheese dependency since the offending gnomecc plug was replaced with the native lp:switchboard-plug-useraccounts

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Makes Displays plug crash with message about having not initialized clutter

review: Needs Fixing
Revision history for this message
Cody Garver (codygarver) wrote :

Fixed crash

review: Abstain
546. By Cody Garver

Drop cheese dependency since the offending gnomecc plug was replaced with the native lp:switchboard-plug-useraccounts

Revision history for this message
Rico Tzschichholz (ricotz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-08-01 13:18:10 +0000
+++ CMakeLists.txt 2015-04-09 08:29:29 +0000
@@ -86,6 +86,7 @@
86endif ()86endif ()
8787
88set (LIB_PACKAGES88set (LIB_PACKAGES
89 clutter-gtk-1.0
89 glib-2.090 glib-2.0
90 gio-2.091 gio-2.0
91 gee-0.892 gee-0.8
@@ -95,14 +96,13 @@
95)96)
9697
97set (LIB_PKG98set (LIB_PKG
99 clutter-gtk-1.0
98 glib-2.0>=2.32100 glib-2.0>=2.32
99 gio-2.0101 gio-2.0
100 gee-0.8102 gee-0.8
101 gmodule-2.0103 gmodule-2.0
102 gtk+-3.0>=3.10104 gtk+-3.0>=3.10
103 gio-unix-2.0105 gio-unix-2.0
104 # cheese is required for the GCC panels to work
105 cheese-gtk
106)106)
107find_package(PkgConfig)107find_package(PkgConfig)
108108
109109
=== modified file 'src/Switchboard.vala'
--- src/Switchboard.vala 2015-03-10 10:01:54 +0000
+++ src/Switchboard.vala 2015-04-09 08:29:29 +0000
@@ -17,9 +17,6 @@
1717
18namespace Switchboard {18namespace Switchboard {
1919
20 [CCode (cname = "cheese_gtk_init")]
21 public extern static bool cheese_gtk_init ([CCode (array_length_pos = 0.9)] ref unowned string[] argv);
22
23 public enum WindowState {20 public enum WindowState {
24 NORMAL = 0,21 NORMAL = 0,
25 MAXIMIZED = 122 MAXIMIZED = 1
@@ -27,10 +24,8 @@
2724
28 public static int main (string[] args) {25 public static int main (string[] args) {
2926
30 // FIXME the gcc user-accounts plug requires cheese to be initialized before gtk,27 // Only known plug that requires GtkClutter is switchboard-plug-display
31 // otherwise it will crash switchboard if it's loaded before the window and28 GtkClutter.init (ref args);
32 // all its widgets are displayed.
33 cheese_gtk_init (ref args);
3429
35 var app = SwitchboardApp.instance;30 var app = SwitchboardApp.instance;
36 return app.run (args);31 return app.run (args);

Subscribers

People subscribed via source and target branches

to all changes: