Merge lp:~codygarver/switchboard/no-cheese-please into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Cody Garver
Status: Merged
Approved by: Cody Garver
Approved revision: 546
Merged at revision: 551
Proposed branch: lp:~codygarver/switchboard/no-cheese-please
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 54 lines (+4/-9)
2 files modified
CMakeLists.txt (+2/-2)
src/Switchboard.vala (+2/-7)
To merge this branch: bzr merge lp:~codygarver/switchboard/no-cheese-please
Reviewer Review Type Date Requested Status
Rico Tzschichholz Approve
Cody Garver (community) Abstain
Review via email: mp+255616@code.launchpad.net

Commit message

Drop cheese dependency since the offending gnomecc plug was replaced with the native lp:switchboard-plug-useraccounts

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Makes Displays plug crash with message about having not initialized clutter

review: Needs Fixing
Revision history for this message
Cody Garver (codygarver) wrote :

Fixed crash

review: Abstain
546. By Cody Garver

Drop cheese dependency since the offending gnomecc plug was replaced with the native lp:switchboard-plug-useraccounts

Revision history for this message
Rico Tzschichholz (ricotz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-08-01 13:18:10 +0000
3+++ CMakeLists.txt 2015-04-09 08:29:29 +0000
4@@ -86,6 +86,7 @@
5 endif ()
6
7 set (LIB_PACKAGES
8+ clutter-gtk-1.0
9 glib-2.0
10 gio-2.0
11 gee-0.8
12@@ -95,14 +96,13 @@
13 )
14
15 set (LIB_PKG
16+ clutter-gtk-1.0
17 glib-2.0>=2.32
18 gio-2.0
19 gee-0.8
20 gmodule-2.0
21 gtk+-3.0>=3.10
22 gio-unix-2.0
23- # cheese is required for the GCC panels to work
24- cheese-gtk
25 )
26 find_package(PkgConfig)
27
28
29=== modified file 'src/Switchboard.vala'
30--- src/Switchboard.vala 2015-03-10 10:01:54 +0000
31+++ src/Switchboard.vala 2015-04-09 08:29:29 +0000
32@@ -17,9 +17,6 @@
33
34 namespace Switchboard {
35
36- [CCode (cname = "cheese_gtk_init")]
37- public extern static bool cheese_gtk_init ([CCode (array_length_pos = 0.9)] ref unowned string[] argv);
38-
39 public enum WindowState {
40 NORMAL = 0,
41 MAXIMIZED = 1
42@@ -27,10 +24,8 @@
43
44 public static int main (string[] args) {
45
46- // FIXME the gcc user-accounts plug requires cheese to be initialized before gtk,
47- // otherwise it will crash switchboard if it's loaded before the window and
48- // all its widgets are displayed.
49- cheese_gtk_init (ref args);
50+ // Only known plug that requires GtkClutter is switchboard-plug-display
51+ GtkClutter.init (ref args);
52
53 var app = SwitchboardApp.instance;
54 return app.run (args);

Subscribers

People subscribed via source and target branches

to all changes: