Code review comment for lp:~codekaki/openerp-hr/7.0-hr_roster

Revision history for this message
Daniel Reis (dreis-pt) wrote :

You will have cases where a person will not be on the roster for the full month. How about adding start and end dates for employees on rosters? (though this may not be easy to implement)

I also noticed that access rules are missing ("WARNING openerp.modules.loading: The model hr.duty_roster_shift has no access rules, consider adding one. E.g. access_hr_duty_roster_shift,access_hr_duty_roster_shift,model_hr_duty_roster_shift,,1,1,1,1" ...)

I believe you are still working on this, so I'm setting the MP as WIP.

« Back to merge proposal