Code review comment for lp:~cmm2-deactivatedaccount/pantheon-files/memory-leak-fixes

I need to look into it, but I suspect the initial 70-100M allocation is not actually used, but is simply freed memory that the allocator has not released to the OS. This explains why subsequent operations do not expand the total memory amount.

The blame for this additional memory requirement seems to fall on marlin_file_changes_consume and marlin_undo_manager (or whatever they are named -- sorry, I'm writing this from a tablet). Both can be optimized: file changes should go out immediately, and not queue up infinitely; and the undo tracker should remember user input, not a recursive list of all source files.

Some file managers don't track destination files for undoing if they belong to a created subdirectory, thus making their aftermath memory requirement effectively nil.

> You inserted a TODO - were you going to do this in this branch or later?

Probably sometime later. If the selected_files problem was causing known crashes I'd fix it, but right now it seems like a pedantic hypothetical.