Code review comment for lp:~cmm2-deactivatedaccount/pantheon-files/memory-leak-fixes
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks for continuing to work on this cmm2! The branch substantially reduces memory usage on copy and deleting 250000 files as described. On my system, one cycle of the test described increased memory usage by over 500MB whereas in the branch it increased by about 75MB (Using System Monitor). For comparison, Thunar's memory increased by about 100MB. PCManFM however, used no extra memory (!) provided the files were not displayed. Presumably some information is still cached in Files and Thunar so this is not necessarily a leak?
No problems with the code.
You inserted a TODO - were you going to do this in this branch or later?
I'd like to test the branch for regressions but subject to that I will approve. Thanks again.