lp:~cmiller/ubuntuone-android-music/null-parent-directory

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntuone-android-music at revision 458

Martin Albisetti (community): Approve on 2010-10-08

Diff: 25 lines (+8/-5)

1 file modified

src/net/sourceforge/subsonic/androidapp/util/FileUtil.java (+8/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #652542: In Offline mode, instead of list of the artists I get a non-descriptive "null"

Medium

Fix Released

Link a bug report

Related blueprints

458. By Chad Miller on 2010-10-08

The String.lastIndexOf sep was too clever and too dumb. "//foo" would fail.

Instead, push the decision about whether there's a parent directory into the File class, and don't poorly LBYL.

457. By Chad Miller on 2010-10-07

Avoid unsafe object addition to make Strings. (LP: 652542)

Ubuntu One servers gave out bad "path" attributes on directory+child XML
documents, so it exposed a bug where the MusicDirectory.Entry path could
have no slashes and cause the parent directory of all stored files to be the
word "null".

Now, Test if any non-first character of the song path is the directory
separator, and only if it is, then trust that path to be splitable into some
filename and a parent path. Else, constuct the path as if the song path is
null.

456. By Chad Miller on 2010-10-07

Prefer external storage as app installation location.

Bump version number.

455. By Chad Miller on 2010-10-07

Never try to parse a document for which we didn't get an affirmative HTTP response code.

454. By Chad Miller on 2010-10-07

Merge several miscellaneous fixes:

Do not poll a server while there are no credentials to send in the URL.
Turn on all lint warnings.
Remove bad=old dumps of serialized data. No need to try parsing them again.
Exponential backoff of REST API attempts.
Remove duplicate artist parsing.

453. By Chad Miller on 2010-10-07

Hide bitrate if we don't have it, and omit file type if unknown

452. By Chad Miller on 2010-10-07

Merge contributed Last.fm scrobbling from Scott Ferguson

451. By Chad Miller on 2010-10-05

Comparators require an int to be returned, but we're subtracting longs, and the result of subtraction may not fit in an int, and then the sky falls down. Reverting my dumb idea for saving function calls and comparisons of relatively small lists.

450. By Chad Miller on 2010-10-05

Try to handle undefined value better. Since we now care whether a defined cache-size can fit on disk, we also now care whether the cache size is defined.

449. By Chad Miller on 2010-10-05

Fix bad name of function that says it returns MB count, but really returns B.