Code review comment for lp:~cmiller/ubuntu/trusty/icewm/translations-cause-crash-lp447883

Dmitry Shachnev (mitya57) wrote :

Thanks for your work here.

- The patch contains come unrelated changes (like 65536.0 → FLOAT_65K change), please drop that and keep diff minimal;
- Please submit the patch upstream so that we don't have to carry a delta;
- Please add a proper changelog entry (with credits to original patch author).

review: Needs Fixing

« Back to merge proposal