juju-core

Code review comment for lp:~cmars/juju-core/resolve-cs-series

  1. resolve-cs-series
  2. Merge into trunk
Revision history for this message
William Reade (fwereade) wrote :

LGTM with one trivial. Thanks for this, it's a monster diff -- let's
throw it at CI and see what we've missed ;).

https://codereview.appspot.com/80280043/diff/140001/charm/url_test.go
File charm/url_test.go (right):

https://codereview.appspot.com/80280043/diff/140001/charm/url_test.go#newcode292
charm/url_test.go:292: c.Check(parsed, gc.DeepEquals, ref)
add one for unmarshalling gibberish, just for safety's sake

https://codereview.appspot.com/80280043/

« Back to merge proposal