https://codereview.appspot.com/80280043/diff/60001/cmd/juju/addmachine.go#newcode129
cmd/juju/addmachine.go:129: series = conf.PreferredSeries()
On 2014/04/01 07:10:07, fwereade wrote:
> mm, I rather liked the PreferredSeries(conf) spelling, especially if
it were
> using an interface with just the DefaultSeries method. This doesn't
feel
> fundamental to a config -- does that seem sane?
Will do. Should this live in environs/config or a different package?
Thanks for reviewing. Couple of questions:
https:/ /codereview. appspot. com/80280043/ diff/60001/ cmd/juju/ addmachine. go addmachine. go (right):
File cmd/juju/
https:/ /codereview. appspot. com/80280043/ diff/60001/ cmd/juju/ addmachine. go#newcode129 addmachine. go:129: series = conf.PreferredS eries() (conf) spelling, especially if
cmd/juju/
On 2014/04/01 07:10:07, fwereade wrote:
> mm, I rather liked the PreferredSeries
it were
> using an interface with just the DefaultSeries method. This doesn't
feel
> fundamental to a config -- does that seem sane?
Will do. Should this live in environs/config or a different package?
https:/ /codereview. appspot. com/80280043/ diff/60001/ environs/ config/ config. go config/ config. go (right):
File environs/
https:/ /codereview. appspot. com/80280043/ diff/60001/ environs/ config/ config. go#newcode230 config/ config. go:230: return DefaultSeries
environs/
On 2014/04/01 07:10:07, fwereade wrote:
> How do we determine the value of this? I'm feeling like it really
ought to
> actually *be* the latest LTS, rather than just some global var set by
> who-knows-who.
I can try to get this from 'distro-info --lts'. If that fails to exec,
I'll use a hard-coded fallback (named as such). What do you think?
https:/ /codereview. appspot. com/80280043/