Code review comment for lp:~cmars/juju-core/resolve-cs-series

Revision history for this message
Casey Marshall (cmars) wrote :

Reviewers: mp+212755_code.launchpad.net,

Message:
Please take a look.

Description:
Resolve series with charm store in juju client.

For the deploy and upgradecharm commands, when a series is not provided,
and a
default-series is not set in the environment config, the client will
resolve
the series with the charm store, through the state server. If the
client is
working with a 1.16 state server, it will resolve the series directly
with the
charm store.

Existing environments will have a default-series, so they should have no
change in series selection.

New environments will continue to support the default-series config
setting,
but it can be omitted, and is not set by default.

https://code.launchpad.net/~cmars/juju-core/resolve-cs-series/+merge/212755

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/80280043/

Affected files (+189, -32 lines):
   A [revision details]
   M charm/charm.go
   M charm/charm_test.go
   M cmd/juju/deploy.go
   M cmd/juju/publish.go
   M cmd/juju/upgradecharm.go
   M environs/bootstrap/synctools.go
   M environs/config/config.go
   M juju/testing/conn.go
   M state/api/client.go
   M state/apiserver/client/client.go
   M state/apiserver/client/client_test.go

« Back to merge proposal