https://codereview.appspot.com/76860044/diff/120001/state/apiserver/client/client_test.go#oldcode663
state/apiserver/client/client_test.go:663: // TODO(fwereade) make these
errors consistent one day.
If these errors are starting to look nicer, please drop the comment (and
the one below). If they're not, would you upgrade this to a tech-debt
bug and fill in the usual TODO template (name, date, bug#, \n, short
description)?
LGTM, I think these are all trivials
https:/ /codereview. appspot. com/76860044/ diff/120001/ charm/url_ test.go
File charm/url_test.go (right):
https:/ /codereview. appspot. com/76860044/ diff/120001/ charm/url_ test.go# newcode167 test.go: 167: c.Assert( err.Error( ), gc.Equals, lvedUrl. Error() )
charm/url_
charm.ErrUnreso
We'd usually check for direct equality with ErrUnresolvedUrl, and
otherwise use gc.ErrorMatches to check the string.
https:/ /codereview. appspot. com/76860044/ diff/120001/ charm/url_ test.go# newcode213 test.go: 213: {charm. IsValidSeries, "pre-c1se", true},
charm/url_
Explicit test that precise-1 is not allowed, but precise1 is?
https:/ /codereview. appspot. com/76860044/ diff/120001/ state/apiserver /client/ client_ test.go /client/ client_ test.go (left):
File state/apiserver
https:/ /codereview. appspot. com/76860044/ diff/120001/ state/apiserver /client/ client_ test.go# oldcode663 /client/ client_ test.go: 663: // TODO(fwereade) make these
state/apiserver
errors consistent one day.
If these errors are starting to look nicer, please drop the comment (and
the one below). If they're not, would you upgrade this to a tech-debt
bug and fill in the usual TODO template (name, date, bug#, \n, short
description)?
https:/ /codereview. appspot. com/76860044/ diff/120001/ store/server. go
File store/server.go (right):
https:/ /codereview. appspot. com/76860044/ diff/120001/ store/server. go#newcode80 URL{Reference: ref, Series:
store/server.go:80: return &charm.
DefaultSeries}
I'm not seeing where this is called. Dead code?
https:/ /codereview. appspot. com/76860044/