Please take a look.
https://codereview.appspot.com/76860044/diff/60001/charm/repo.go File charm/repo.go (right):
https://codereview.appspot.com/76860044/diff/60001/charm/repo.go#newcode154 charm/repo.go:154: curl = &*curl On 2014/03/18 01:01:10, dfc wrote: > I don't understand what this line does. I think it does nothing. If if does > something then it need a comment to explain the magic.
It doesn't do what I think it did. :\
https://codereview.appspot.com/76860044/diff/60001/charm/repo.go#newcode429 charm/repo.go:429: result := &*curl On 2014/03/18 01:01:10, dfc wrote: > yuk, how about
> result := *curl > if !result ... {
> } > return &result, nil
Done.
https://codereview.appspot.com/76860044/diff/60001/store/server.go File store/server.go (right):
https://codereview.appspot.com/76860044/diff/60001/store/server.go#newcode80 store/server.go:80: curl.Series = "precise" On 2014/03/18 01:01:10, dfc wrote: > please make this a constant at the top of the file with a comment explaining the > effect of changing the constant.
https://codereview.appspot.com/76860044/
« Back to merge proposal
Please take a look.
https:/ /codereview. appspot. com/76860044/ diff/60001/ charm/repo. go
File charm/repo.go (right):
https:/ /codereview. appspot. com/76860044/ diff/60001/ charm/repo. go#newcode154
charm/repo.go:154: curl = &*curl
On 2014/03/18 01:01:10, dfc wrote:
> I don't understand what this line does. I think it does nothing. If if
does
> something then it need a comment to explain the magic.
It doesn't do what I think it did. :\
https:/ /codereview. appspot. com/76860044/ diff/60001/ charm/repo. go#newcode429
charm/repo.go:429: result := &*curl
On 2014/03/18 01:01:10, dfc wrote:
> yuk, how about
> result := *curl
> if !result ... {
> }
> return &result, nil
Done.
https:/ /codereview. appspot. com/76860044/ diff/60001/ store/server. go
File store/server.go (right):
https:/ /codereview. appspot. com/76860044/ diff/60001/ store/server. go#newcode80
store/server.go:80: curl.Series = "precise"
On 2014/03/18 01:01:10, dfc wrote:
> please make this a constant at the top of the file with a comment
explaining the
> effect of changing the constant.
Done.
https:/ /codereview. appspot. com/76860044/