Code review comment for lp:~cmars/juju-core/no-default-series

Reviewers: mp+211389_code.launchpad.net,

Message:
Please take a look.

Description:
Resolve implicit series with charm store.

Charm URLs without a series are "unresolved". A charm repository can
resolve
the series. Charm store service resolves the series by adding
CanonicalURL to
the charm info if it is found & resolved. Local repository uses default
series as configured in the environment. Command-line tools interacting
with
a charm repo are responsible for making requests with resolved charm
URLs.
State server requires a resolved charm URL for such requests. Charm
store
service initially resolves series to a hard-coded value -- to be
replaced by
more advanced logic as we transition to new LTS. Updated unit tests &
mocks
accordingly.

https://code.launchpad.net/~cmars/juju-core/no-default-series/+merge/211389

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/76860044/

Affected files (+222, -79 lines):
   A [revision details]
   M charm/charm.go
   M charm/charm_test.go
   M charm/repo.go
   M charm/repo_test.go
   M charm/testing/mockstore.go
   M charm/url.go
   M charm/url_test.go
   M cmd/juju/deploy.go
   M cmd/juju/publish.go
   M cmd/juju/publish_test.go
   M cmd/juju/upgradecharm.go
   M cmd/juju/upgradecharm_test.go
   M environs/config/config.go
   M environs/jujutest/livetests.go
   M juju/conn_test.go
   M state/apiserver/client/client.go
   M state/apiserver/client/client_test.go
   M store/server.go
   M store/server_test.go
   M testing/charm.go