Code review comment for lp:~cmars/juju-core/local-repo-errmsg

Revision history for this message
Casey Marshall (cmars) wrote :

Please take a look.

https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go
File cmd/juju/deploy.go (right):

https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go#newcode55
cmd/juju/deploy.go:55: However, for local charms, such as
local:precise/mysql, one must specify the
On 2014/04/09 20:13:33, curtis wrote:
> I see "assuming a current default series of" in the text above. That
is
> ambiguous. I din't know if that means the charm's default series or
the
> environment's default-series.

Added a sentence to disambiguate.

> Maybe this phrasing is helpful
> However, for local charms, where the default-series is not
specified in the
> environment, one must specify the series.

Done.

> Older versions of juju had default-series in the env template created
by "juju
> init". Many of my envs have a define default-series because juju put
it there.
> So new local users of the past few months are the common victims of
this change.
> Maybe the local template should a default-series line commented out to
help
> users discover the feature.

Where does this template live? I see the templates for specific
providers, but none of them contain a commented default-series: as far
as I can tell.

My environment.yaml has a commented default-series, but it was generated
ages ago.

https://codereview.appspot.com/86160043/

« Back to merge proposal