Code review comment for lp:~cmars/charms/precise/haproxy/trunk

Revision history for this message
Benjamin Saller (bcsaller) wrote :

Thanks for this. I was unable to get the tests to run proper (as you indicated) which means we can't continue.

As far as helping with the (admittedly tricky) mocking issue you're seeing a series of changes like

    @patch.dict(os.environ, {"JUJU_UNIT_NAME": "haproxy/2"})
    @patch('hooks.config_get')
    def test_creates_a_listen_stanza_with_tuple_entries(self, mconfig):
        mconfig.side_effect = [None, None]

Will result in those tests passing.

Again, thank you.

review: Needs Fixing

« Back to merge proposal