Code review comment for lp:~cmars/charms/precise/haproxy/trunk

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Hi Casey, unfortunately this currently breaks `make build` for the charm. Since tests aren't passing post merge I'm unable to approve this. FWIW, your changes seem good - the tests will simply need to be updated to reflect your changes.

--

Once you're able to get the tests passing and wish for another review, make sure to "Request another review" from "charmers" to have this added back to the queue again. Thanks for the work so far!

review: Needs Fixing

« Back to merge proposal