Code review comment for lp:~cloudbuilders/nova/os-keypair-integration

Revision history for this message
Jesse Andrews (anotherjesse) wrote :

> As for making this v1.1-only, I think you just need to move line 92 into a
> version-specific view builder in that same module. We can't really do much
> about versioning create_instance_helper at the moment.

A view is what happens on the way out (response) not for determining how to add a keypair on create.

I did so by adding a create method to the ControllerV10 but the tests now fail - because it seems that my use of super breaks stubs?

« Back to merge proposal