Merge lp:~clissold345/ubuntu-docs/fix-for-1617718 into lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10

Proposed by Chris Perry
Status: Merged
Merged at revision: 558
Proposed branch: lp:~clissold345/ubuntu-docs/fix-for-1617718
Merge into: lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10
Diff against target: 133 lines (+27/-32)
2 files modified
ubuntu-help/C/mouse-middleclick.page (+12/-12)
ubuntu-help/C/mouse-touchpad-click.page (+15/-20)
To merge this branch: bzr merge lp:~clissold345/ubuntu-docs/fix-for-1617718
Reviewer Review Type Date Requested Status
Gunnar Hjalmarsson Approve
Review via email: mp+308003@code.launchpad.net

Description of the change

The bug poster (Oxwivi) says that the multi-finger tap for middle-click doesn't work as documented (on touchpads that support multi-finger taps of course). So the current help is definitely wrong. The bug mentions middle-click but the help is wrong for right-click too.

I've checked on my laptop and this works:

- To right-click, tap once in the bottom right-hand corner.

- To middle-click, tap once in the top right-hand corner.

I'm assuming that all touchpads can detect taps in the corners. I've updated the help so that it describes right-clicks and middle-clicks from the touchpad as given above. I'm using the terms "middle-click" and "right-click".

In mouse-middle-click.page I've revised the section on applications so that it doesn't mention mice (since middle-click isn't necessarily generated by a mouse). I deleted the word "advanced" since I don't think it adds anything. I haven't tried to check all the details given about applications.

In mouse-touchpad-click.page the first sentence describes the page as a whole, then a sub section starts, so I've added markup to indicate a new section. The note given on the first procedure wasn't needed in my opinion so I've deleted it. I haven't checked or altered the sections "Two finger scroll" or "Content sticks to fingers".

I did a validate. No errors were reported.

To post a comment you must log in.
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

This makes sense to me.

While I'm going to merge this branch, I subscribed Oxwivi (the bug reporter). So @Oxwivi, if you find that there is something left unaddressed, please let us know.

Thanks for the great work, Chris!

review: Approve
Revision history for this message
Oxwivi (oxwivi) wrote :

I'm sorry for my late response. I don't see any issues with the change
either (though it's already too late to get a word in). Thank you for for
responding to my bug report and fixing it.

On Tue, Oct 11, 2016 at 9:25 PM <email address hidden> wrote:

> The proposal to merge lp:~clissold345/ubuntu-docs/fix-for-1617718 into
> lp:ubuntu-docs has been updated.
>
> Status: Needs review => Merged
>
> For more details, see:
>
> https://code.launchpad.net/~clissold345/ubuntu-docs/fix-for-1617718/+merge/308003
> --
> You are subscribed to branch lp:~clissold345/ubuntu-docs/fix-for-1617718.
>

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

No, it's not too late, Oxwivi. We can make further changes if needed. :)

Revision history for this message
Oxwivi (oxwivi) wrote :

Ah, I mean, merge proposal's already up...

Anyway, I think there was a specific term for the middle-click's clipboard
(which I don't recall). While it's not important, maybe it'd be good to
include it, so the user knows what to call it if there's any question or
issues about it.

On Tue, Oct 11, 2016 at 9:45 PM Gunnar Hjalmarsson <
<email address hidden>> wrote:

> No, it's not too late, Oxwivi. We can make further changes if needed. :)
> --
>
> https://code.launchpad.net/~clissold345/ubuntu-docs/fix-for-1617718/+merge/308003
> You are subscribed to branch lp:~clissold345/ubuntu-docs/fix-for-1617718.
>

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Okay.. I for one am not aware of a specific term. Just googled and found <http://askubuntu.com/q/167570> where they talk about some distinction between the X clipboard and the desktop environment clipboard. However, that would be 'too technical' for the desktop guide.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-help/C/mouse-middleclick.page'
2--- ubuntu-help/C/mouse-middleclick.page 2013-10-23 04:16:46 +0000
3+++ ubuntu-help/C/mouse-middleclick.page 2016-10-09 11:44:53 +0000
4@@ -29,7 +29,7 @@
5
6 <title>Middle-click</title>
7
8-<p>Many mice and some touchpads have a middle mouse button. On a mouse
9+<p>Many mice have a middle mouse button. On a mouse
10 with a scroll wheel, you can usually press directly down on the scroll
11 wheel to middle-click. If you don't have a middle mouse button, you
12 can press the left and right mouse buttons at the same time to
13@@ -37,22 +37,22 @@
14 can try following <link href="https://wiki.ubuntu.com/X/Quirks#A2-button_Mice">
15 these instructions</link>.</p>
16
17-<p>On touchpads that support multi-finger taps, you can tap with three
18-fingers at once to middle-click. You have to
19+<p>Some touchpads have a middle mouse button and some do not.
20+ On touchpads that don't have a middle mouse button you can middle-click
21+ by tapping once in the top right-hand corner of the touchpad. You have to
22 <link xref="mouse-touchpad-click">enable tap clicking</link> in the
23 touchpad settings for this to work.</p>
24
25-<p>Many applications use middle-click for advanced click shortcuts.</p>
26+<p>Many applications use middle-click for shortcuts:</p>
27
28 <list>
29 <item><p>One common shortcut is to paste selected text. (This is sometimes
30 called primary selection paste.) Select the text you want to paste, then go
31 to where you want to paste it and middle-click. The selected text is pasted
32- at the mouse position.</p>
33- <p>Pasting text with your middle mouse button is completely separate
34+ at the cursor position.</p>
35+ <p>Pasting text using middle-click is completely separate
36 from the normal clipboard. Selecting text does not copy it to your
37- clipboard. This quick method of pasting only works with the middle
38- mouse button.</p></item>
39+ clipboard. This quick method of pasting only works with middle-click.</p></item>
40
41 <item><p>On scrollbars and sliders, a regular click in the empty space moves
42 by a set amount (such as one page) in the direction you clicked. You can also
43@@ -66,8 +66,8 @@
44 the <gui>Launcher</gui> on the left, or in
45 the <gui>Dash</gui>.</p></item>
46
47- <item><p>Most web browsers allow you to open links in tabs quickly with the
48- middle mouse button. Just click any link with your middle mouse button, and
49+ <item><p>Most web browsers allow you to open links in tabs quickly with middle-click.
50+ Just middle-click any link, and
51 it will open in a new tab. Be careful clicking the link in the <app>Firefox</app>
52 web browser, though. In <app>Firefox</app>, if you middle-click anywhere except
53 on a link, it will try to load your selected text as a URL, as if you used
54@@ -80,7 +80,7 @@
55 will open the file, just as if you had double-clicked.</p></item>
56 </list>
57
58-<p>Some specialized applications allow you to use the middle mouse
59-button for other functions. Search your application's help for
60+<p>Some specialized applications allow you to use middle-click
61+for other functions. Search your application's help for
62 <em>middle-click</em> or <em>middle mouse button</em>.</p>
63 </page>
64
65=== modified file 'ubuntu-help/C/mouse-touchpad-click.page'
66--- ubuntu-help/C/mouse-touchpad-click.page 2013-10-23 04:16:46 +0000
67+++ ubuntu-help/C/mouse-touchpad-click.page 2016-10-09 11:44:53 +0000
68@@ -22,37 +22,31 @@
69
70 <title>Click, drag, or scroll with the touchpad</title>
71
72-<p>You can click, double-click, drag, and scroll using only your
73+<p>If your system has a touchpad, you can click, double-click, drag, and scroll using only your
74 touchpad, without separate hardware buttons.</p>
75
76+<section id="clickordrag">
77+
78+<title>Click or drag</title>
79+
80+<p>You can click or drag using your touchpad.</p>
81+
82 <steps>
83 <item><p>Click the icon at the very right of the <gui>menu bar</gui> and select <gui>System Settings</gui>.</p></item>
84 <item><p>Open <gui>Mouse &amp; Touchpad</gui>.</p></item>
85- <item><p>In the <gui>Touchpad</gui> section, check <gui>Tap to click</gui>.</p>
86- <note>
87- <p>The <gui>Touchpad</gui> section only appears if your system has a
88- touchpad.</p>
89- </note>
90- </item>
91+ <item><p>In the <gui>Touchpad</gui> section, check <gui>Tap to click</gui>.</p></item>
92 </steps>
93
94 <list>
95-<item><p>To click, tap on the touchpad.</p></item>
96+<item><p>To click, tap once (but not in the bottom or top right-hand corners).</p></item>
97 <item><p>To double-click, tap twice.</p></item>
98-<item><p>To drag an item, double-tap but don't lift your finger after the second tap.
99+<item><p>To drag an item, tap twice but don't lift your finger after the second tap.
100 Drag the item where you want it, then lift your finger to drop.</p></item>
101-<item><p>If your touchpad supports multi-finger taps, right-click by tapping with
102-two fingers at once. Otherwise, you still need to use hardware buttons to
103-right-click. See <link xref="a11y-right-click"/> for a method of right-clicking
104-without a second mouse button.</p></item>
105-<item><p>If your touchpad supports multi-finger taps,
106-<link xref="mouse-middleclick">middle-click</link> by tapping with three fingers
107-at once.</p></item>
108+<item><p>To right-click, tap once in the bottom right-hand corner.</p></item>
109+<item><p>To middle-click, tap once in the top right-hand corner.</p></item>
110 </list>
111
112-<note><p>When tapping or dragging with multiple fingers, make sure your fingers
113-are spread far enough apart. If your fingers are too close, your computer may
114-think they're a single finger.</p></note>
115+</section>
116
117 <section id="twofingerscroll">
118
119@@ -87,6 +81,7 @@
120 <note><p>Two-finger scrolling may not work on all touchpads.</p></note>
121
122 </section>
123+
124 <section id="contentsticks">
125
126 <title>Content sticks to fingers</title>
127@@ -107,4 +102,4 @@
128 </note>
129 </section>
130
131-</page>
132\ No newline at end of file
133+</page>

Subscribers

People subscribed via source and target branches