Code review comment for lp:~clint-fewbar/ubuntu/oneiric/upstart/add-plymouth-messages

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Re pause/unpause, I hadn't thought about it much, but I suppose it makes sense that its still "Making progress".

I feel like this is a situation that we're hoping nobody runs into who didn't hack on their system in a weird way. So its best to inform the user of whats going on so they don't get a frustrating experience. Another option would be to watch for a keystroke and let the user skip the wait.. but that seems more complicated than just updating the message a few times while we wait.

The EXIT trap works fine as long as the plymouth command finishes within 5 seconds, but I think I'll take out the pause/unpause anyway, as I have no good reason to do that.

« Back to merge proposal