Ubuntu
upstart package

Code review comment for lp:~clint-fewbar/ubuntu/oneiric/upstart/add-plymouth-messages

  1. Oneiric (11.10)
  2. add-plymouth-messages
  3. Merge into oneiric
Revision history for this message
Steve Langasek (vorlon) wrote :

+ $PLYMOUTH pause-progress || :

Why does the progress need to be paused? This probably makes no difference with the standard Ubuntu plymouth theme, since we simply cycle the dots on the screen, but for themes that do care about progress bars I'm not sure pausing is the right thing. Have you tried it without this change?

+ $PLYMOUTH message --text="Waiting for network configuration..." || :
+ sleep 40
+ $PLYMOUTH message --text="Waiting up to 60 more seconds for network configuration..." || :
+ sleep 59

What's the value in having two different messages here instead of just one? Is this to keep the user from thinking the machine has hung? (If so, see above about not pausing progress...?)

+ continue_boot () {
+ $PLYMOUTH unpause-progress || :
+ }

Does this work in practice, or does upstart kill the job with too much force?

Also, I think this leaves the last message on the screen - do we want to clear it instead?

+ sleep 1

Not sure what this buys us - is this to try to ensure there's time to see the message before plymouth exits?

« Back to merge proposal