Code review comment for lp:~clint-fewbar/ubuntu/natty/nfs-utils/wait-for-local-filesystems

Revision history for this message
Steve Langasek (vorlon) wrote :

On Thu, Dec 23, 2010 at 06:01:54AM -0000, Clint Byrum wrote:
> Right.. we do need to stop it at some point... leaving it running means
> the same libc problems and possible open files (it does write
> to /var...) preventing unmounting filesystems cleanly.

Yes, that much is true.

> Would it then make sense to change this to stop on stopping portmap or
> unmounted-nfs-filesystems and then emit that
> in /etc/init.d/umountnfs.sh?

That sounds reasonable to me, but I agree with you that this should be taken
to a separate bug / branch.

> Where would this leave an NFS root? Do we just leave rpc.statd running
> in this case?

Yes, in that case I think it has to stay running until the end.

> I'll poke at that for a bit and see how it goes.

Any progress on this? From the discussions on IRC I think we've got a
pretty good handle now on the scope, so I'm keen to get this fixed up and
merged.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

« Back to merge proposal